1839054 - Enable QPACK dynamic table on Android

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement, P2)

Description

[Gregory Pappas [:gregp]]

QPACK dynamic table was disabled on desktop and mobile in bug 1628460. It was later re-enabled in bug 1655782, but only on desktop.

Comment 1

[edgul]

Hey Martin,
Just wanted to check if you had any concerns around re-enabling this on Android.
Thanks.

Comment 2

[Martin Thomson [:mt:]]

:kershaw can you take a look at this? I think that - given the time involved - the unspecified problem is OK, so we should just turn this back on (and give our Android users better performance).

Comment 3

[Martin Thomson [:mt:]]

Worth noting also: the original table size was 4k for Android. We can probably afford a larger table. 16k at least, though 64k to match desktop is probably fine. Most Android devices have multiple Gb of RAM, so a few kilobytes per connection won't hurt that much. Other decompressors can use a lot more memory than that (zlib uses 40k and that's an old, lightweight algorithm).

Comment 4

[Kershaw Chang [:kershaw]]

(In reply to Martin Thomson [:mt:] from comment #3)

Worth noting also: the original table size was 4k for Android. We can probably afford a larger table. 16k at least, though 64k to match desktop is probably fine. Most Android devices have multiple Gb of RAM, so a few kilobytes per connection won't hurt that much. Other decompressors can use a lot more memory than that (zlib uses 40k and that's an old, lightweight algorithm).

Thanks. I 64k should be fine. Will submit a patch soon.

Comment 5

[Kershaw Chang [:kershaw]]

Attachment: Bug 1839054 - Enable QPACK on Android, r=#necko

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5229dccdcd33
Enable QPACK on Android, r=necko-reviewers,geckoview-reviewers,jesup,amejiamarmol

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/5229dccdcd33