Closed Bug 18392 Opened 20 years ago Closed 20 years ago

[perf] avoid reload/reparse master XUL document for chrome

Categories

(Core :: XUL, defect, P1)

defect

Tracking

()

VERIFIED FIXED

People

(Reporter: waterson, Assigned: waterson)

References

Details

Attachments

(1 file)

Even though "brutal sharing" is on and enabled, the master documents (and any
script and style sheets associated with them) are still reparsed each time a new
window is opened. Hack webshell's LoadURL() method to check in the XUL prototype
cache before sending necko off to fetch 'chrome:' URLs.
Status: NEW → ASSIGNED
Target Milestone: M12
Priority: P3 → P1
Blocks: 19421
That's not quite true, is it?  Scripts and style sheets are cached.  It's only
the XUL.
Script sources are not cached since my share-compiled-scripts-via-prototypes
work went in.  That means the master doc is reloading source through necko.  We
don't need to restore the script cache, methinks -- we should just send load
events from the necko-bypass/prototype-cache-hit case for the master, like we do
(or try to do, modulo bugs) for subdocs.

/be
Attached patch webshell changesSplinter Review
XUL-side stuff is checked in. Awaiting review and blessing from mscott/travis
for webshell changes.
Depends on: 20076
travis, mscott: take a look at the patch that I have to nsWebShell.cpp. Lemme
know what the "Real" way to do this will be...
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
fix checked in. now it's time to go pick up the pieces.
Status: RESOLVED → VERIFIED
QA Contact: ckritzer → paulmac
marking verified
BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL.  XUL 
component will be deleted.
Component: XUL → XP Toolkit/Widgets: XUL
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: paulmac → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.