1839286 - ImageBitmap can create a lot shutdown observers, which are managed by an array

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Timothy Nikkel (:tnikkel)]

This makes bug 1508765 slower for example.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1839286. Use one shutdown observer for all ImageBitmaps. r?#gfx-reviewers

Use on shutdown observer and manager a hashtable of all imagebitmaps. Observers are managed using an array, which is slow for large numbers of observers.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1414825

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec7fc33e6ad4
Use one shutdown observer for all ImageBitmaps. r=gfx-reviewers,lsalzman

Comment 4

[Marco Castelluccio [:marco]]

Very long standing regression, not worth uplifting.

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out changeset ec7fc33e6ad4 (Bug 1839286) for causing multiple failures

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=aN-JwzYPQVW1Kbxm85ZKpA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=ec7fc33e6ad43b6acf7d1cce0a931725dca2a2d7

Log: https://treeherder.mozilla.org/logviewer?job_id=419945660&repo=autoland&lineNumber=3751
https://treeherder.mozilla.org/logviewer?job_id=419944713&repo=autoland&lineNumber=6684
https://treeherder.mozilla.org/logviewer?job_id=419941275&repo=autoland&lineNumber=18869
https://treeherder.mozilla.org/logviewer?job_id=419943565&repo=autoland&lineNumber=52958
https://treeherder.mozilla.org/logviewer?job_id=419957015&repo=autoland
https://treeherder.mozilla.org/logviewer?job_id=419948618&repo=autoland&lineNumber=5966

Backout: https://hg.mozilla.org/integration/autoland/rev/0f4b571e4029fa57a6c8c4f1ae7bab13819d0096

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1414825

Comment 7

[Dianna Smith [:diannaS]]

:tnikkel any update on this?

Comment 8

[Timothy Nikkel (:tnikkel)]

Have a patch that passes try, still want to think it over with fresh eyes to make sure my logic is sound.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1cf8313960e0
Use one shutdown observer for all ImageBitmaps. r=gfx-reviewers,lsalzman

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1cf8313960e0

Comment 11

[Dianna Smith [:diannaS]]

:tnikkel thank you! i think this can ride the 117 train, but let me know if you think otherwise