1839310 - test_autocomplete_with_composition_on_input.html is too slow

Status: ASSIGNED

(Toolkit :: Autocomplete, defect, P1)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The test takes a couple of minutes or more because of wrong condition here:
https://searchfox.org/mozilla-central/rev/a5da23c8c9c1151dcdf0ca34b3cfd0a4d0fc3b48/toolkit/content/tests/chrome/file_autocomplete_with_composition.js#79-82

      waitForCondition(() => {
        this._controller.searchStatus >=
          Ci.nsIAutoCompleteController.STATUS_COMPLETE_NO_MATCH;
      }, this._checkResult.bind(this));

nsIAutoCompleteController.searchStatus may be other values because nsAutoCompleteController::StartSearch() does not reset the state. I think that this can be != Ci.nsIAutoCompleteController.STATUS_SEARCHING.

(I think that it's too risky to update mSearchStatus with composition state change because it may not represent the state in some cases, e.g., even if StopSearch() is called, it may be set to STATUS_COMPLETE_* or stay STATUS_NONE, so, it's hard to use the value in some cases.)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Oh, and also the arrow function never returns true because it does not have return statement even though wrapping with {}...

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Trying: https://treeherder.mozilla.org/jobs?repo=try&revision=2de47dc91713fd89d86d939ddae2631711281385

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1839310 - Make `nsDoTestsForAutoCompleteWithComposition.prototype._doTests` restart test if the state is not "searching" r=sgalich!

nsAutoCompleteController::mSearchStatus may be STATUS_NONE,
STATUS_COMPLETE_NO_MATCH or STATUS_COMPLETE_MATCH while it temporarily
stops working due to active IME composition because it's not updated with
composition state change. From point of view of the test, the important
point is, it's not searching and won't popup the suggest list. Therefore,
it's enough to check whether the state is no STATUS_SEARCHING.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0748dcb01937
Make `nsDoTestsForAutoCompleteWithComposition.prototype._doTests` restart test if the state is not "searching" r=sgalich

Comment 5

[Atila Butkovits]

Backed out for causing high frequency failures at test_findbar.xhtml.

Backout link: https://hg.mozilla.org/integration/autoland/rev/acd49b43bfd01a05d87dc506aafc2b36f2fcb74e

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=0748dcb01937c565e3a27843969b79b0c25783ca&selectedTaskRun=Z2stDkINQDiPJuzOH-rKOA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=421384293&repo=autoland&lineNumber=5113

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

That's odd. It seems that something is not correctly reset in the test.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:serg, could you have a look please?

For more information, please visit BugBot documentation.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:masayuki, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I still don't have much time to investigate the failure of test_findbar.xhtml which runs after the test.