Closed Bug 1839424 Opened 2 years ago Closed 2 years ago

Handle transform changes more simply.

Categories

(Core :: Graphics: Canvas2D, defect)

defect

Tracking

()

RESOLVED FIXED
116 Branch
Tracking Status
firefox116 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

Details

Attachments

(1 file)

This changes how we deal with transform changes during path construction.
Previously, we would switch to storing the path in device space and keeping it
there until it was used.

This switches us to the same strategy that WebKit and Blink use: Just transform
the old path to the new user space.

There are definitely some cases where this will give worse performance but it's
simpler and it also means we'll have the same performance characteristics as
other browsers. It also makes it easier for us to pass arcs down to the underlying
DrawTarget.

This changes how we deal with transform changes during path construction.
Previously, we would switch to storing the path in device space and keeping it
there until it was used.

This switches us to the same strategy that WebKit and Blink use: Just transform
the old path to the new user space.

There are definitely some cases where this will give worse performance but it's
simpler and it also means we'll have the same performance characteristics as
other browsers. It also makes it easier for us to pass arcs down to the underlying
DrawTarget.

Pushed by jmuizelaar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/635bd3e302b2 Handle transform changes more simply. r=lsalzman
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
Regressions: 1849458
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: