1839532 - Search dialog broken with error in tree-selection.mjs: can't access property "selectEventsSuppressed", selection is null

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Geoff Lankow (:darktrojan)]

The tests browser_folderTreeQuirks.js and browser_multipleSearchWindows.js are failing. We're being broken by the "fake tree selection" code in folderDisplay.js which, fortunately, we don't need any more. I'll take it out.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1839532 - Remove fake tree selection code from folderDisplay.js. r=#thunderbird-reviewers

We don't use this code any more, and this file is now only used in the Search Messages dialog, which is still working fine without it.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b66f123f11fa
Remove fake tree selection code from folderDisplay.js. r=mkmelin

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9340197 [details]
Bug 1839532 - Remove fake tree selection code from folderDisplay.js. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1839066 was uplifted
User impact if declined: search dialog fails
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):

Comment 4

[Daniel Darnell [:dandarnell]]

Thunderbird 115.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/fe2c8801535c

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9340197 [details]
Bug 1839532 - Remove fake tree selection code from folderDisplay.js. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta