Closed
Bug 1839564
Opened 2 years ago
Closed 2 years ago
Change static BigInt to take const pointers where applicable
Categories
(Core :: JavaScript Engine, task)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
116 Branch
| Tracking | Status | |
|---|---|---|
| firefox116 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(3 files)
See https://phabricator.services.mozilla.com/D174160 for context.
|
Assignee | |
Comment 1•2 years ago
|
||
Replace BigInt* with const BigInt* in internal BigInt methods.
|
|
Assignee | |
Comment 2•2 years ago
|
||
Also prefer const pointers in the public JS-API functions.
Depends on D181768
|
|
Assignee | |
Comment 3•2 years ago
|
||
Remove const_cast which is no longer needed after part 1.
Depends on D181770
Pushed by andre.bargull@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/198e544a4107
Part 1: Use const pointers in internal BigInt methods. r=spidermonkey-reviewers,jandem
https://hg.mozilla.org/integration/autoland/rev/4228889cce3b
Part 2: Use const pointers in public JS-API BigInt functions. r=spidermonkey-reviewers,jandem
https://hg.mozilla.org/integration/autoland/rev/522289fefd9c
Part 3: Remove no longer needed const_cast. r=spidermonkey-reviewers,jandem
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/198e544a4107
https://hg.mozilla.org/mozilla-central/rev/4228889cce3b
https://hg.mozilla.org/mozilla-central/rev/522289fefd9c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•