1839682 - Replace the DefaultTimeZone and CanonicalizeTimeZoneName self-hosted functions with their Temporal counterparts

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, task, P3)

Description

[André Bargull [:anba]]

temporal::TimeZone adds C++ implementations of the DefaultTimeZone and CanonicalizeTimeZoneName self-hosted functions. When the Temporal code is enabled by default, we can replace the self-hosted functions with the newer C++ functions.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1839682 - Part 1: Move call to TimeZone::GetCanonicalTimeZoneID into SharedIntlData. r=#spidermonkey-reviewers!

This avoids some duplicated code. The next part will perform further clean-ups.

In addition to that, also provide a way to validate and canonicalise a time zone
name without first constructing a JSString.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1839682 - Part 2: Use Temporal time zone functions for Intl. r=#spidermonkey-reviewers!

Use the Temporal-based functions to avoid duplicated code.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/edc8545f86a4
https://hg.mozilla.org/integration/autoland/rev/397a961e5bd3
Part 1: Move call to TimeZone::GetCanonicalTimeZoneID into SharedIntlData. r=spidermonkey-reviewers,dminor
https://github.com/mozilla-firefox/firefox/commit/6c886aec818b
https://hg.mozilla.org/integration/autoland/rev/7c46bc8f8fa2
Part 2: Use Temporal time zone functions for Intl. r=spidermonkey-reviewers,dminor

Comment 4

[[e-mail]]

Backed out for causing SM bustages failures at DateTime.h
- Backout link

- Push with failures

- Failure log

• Failure line:
  /builds/worker/checkouts/gecko/js/src/vm/DateTime.h:73:27: error: no member named 'intl' in namespace 'mozilla'

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/95ef4b8ee7a7
https://hg.mozilla.org/integration/autoland/rev/b882fb0a8dcf
Part 1: Move call to TimeZone::GetCanonicalTimeZoneID into SharedIntlData. r=spidermonkey-reviewers,dminor
https://github.com/mozilla-firefox/firefox/commit/9da12aeecab9
https://hg.mozilla.org/integration/autoland/rev/f321bcc90a9d
Part 2: Use Temporal time zone functions for Intl. r=spidermonkey-reviewers,dminor

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b882fb0a8dcf
https://hg.mozilla.org/mozilla-central/rev/f321bcc90a9d