1839750 - [deb12] /builds/worker/fetches/winchecksec/pe-parse/pe-parser-library/src/buffer.cpp:187:9: error: dangling pointer ‘tmp’ to ‘tmpBuf’ may be used [-Werror=dangling-pointer=]

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mh [at] glandium.org
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=420087737&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/OPfgummcQzah-H3qSOOcVw/runs/0/artifacts/public/logs/live_backing.log

---

[task 2023-06-21T02:03:49.147Z] /builds/worker/fetches/winchecksec/pe-parse/pe-parser-library/src/buffer.cpp:187:9: error: dangling pointer ‘tmp’ to ‘tmpBuf’ may be used [-Werror=dangling-pointer=]
[task 2023-06-21T02:03:49.147Z]   187 |   out = *tmp;
[task 2023-06-21T02:03:49.147Z]       |         ^~~~
[task 2023-06-21T02:03:49.147Z] /builds/worker/fetches/winchecksec/pe-parse/pe-parser-library/src/buffer.cpp:180:18: note: ‘tmpBuf’ declared here
[task 2023-06-21T02:03:49.147Z]   180 |     std::uint8_t tmpBuf[2];
[task 2023-06-21T02:03:49.147Z]       |                  ^~~~~~
[task 2023-06-21T02:03:52.614Z] /builds/worker/fetches/winchecksec/pe-parse/pe-parser-library/src/parse.cpp:1751:24: error: unsigned conversion from ‘int’ to ‘uint16_t’ {aka ‘short unsigned int’} changes the value of ‘-61441’ [-Werror=sign-conversion]
[task 2023-06-21T02:03:52.614Z]  1751 |         offset = entry & ~0xf000;
[task 2023-06-21T02:03:52.614Z]       |                  ~~~~~~^~~~~~~~~

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1839750 - Apply winchecksec upstream patches to fix errors compiling with newer versions of GCC.

We could upgrade winchecksec, but newer versions of the code unfortunately
require vcpkg.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d5dcd3fb958
Apply winchecksec upstream patches to fix errors compiling with newer versions of GCC. r=firefox-build-system-reviewers,ahochheiden

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/9d5dcd3fb958

Comment 4

[Intermittent Failures Robot]

1 failures in 3880 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform and build breakdown:

• toolchains: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1839750&startday=2023-06-19&endday=2023-06-25&tree=all