1840058 - 0.17% installer size (OSX) regression on Mon June 19 2023

Status: RESOLVED WONTFIX

(Core :: XPCOM, defect)

Description

[Alex Finder]

Perfherder has detected a build_metrics performance regression from push 2e0c179db6fbc7070ab826bc771fa7c04ff51a68. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
0.17%	installer size	osx-shippable	instrumented	125,088,938.12 -> 125,303,581.75

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) may be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1839083

Comment 2

[Markus Stange [:mstange]]

It says "Options: instrumented" in the table above. Does this mean that this code size change only affects the "instrumented" builds we create to gather optimization data as part of the PGO building process, and not the actual final PGO builds?

We don't ship instrumented builds. So I think we can ignore the code size numbers of this type of build.