1840313 - return full TaskQueue class from CreateBackgroundTaskQueue()

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Karl Tomlinson (:karlt)]

TaskQueue methods such as BeginShutdown() and IsEmpty() can be useful to clients.

Only the interface class nsISerialEventTarget was returned over concerns that returning a TaskQueue might imply that clients would need to explicitly shut down the TaskQueue, but this was not correct. TaskQueues do not require explicit shutdown.

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: Bug 1840313 remove declaration of non-existent TaskQueue::CancelDelayedRunnables() r?#xpcom-reviewers

Gone since https://hg.mozilla.org/mozilla-central/rev/ad682061ae5c#l26.116

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: Bug 1840313 return full TaskQueue class from CreateBackgroundTaskQueue() r?#xpcom-reviewers

This makes TaskQueue methods such as BeginShutdown() and IsEmpty() available
to clients.

Only the interface class nsISerialEventTarget was previously returned over
concerns [1] that returning a TaskQueue might imply that clients would need to
explicitly shut down the TaskQueue, but this was not correct. TaskQueues do
not require explicit shutdown [2].

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1584568#c5
[2] https://searchfox.org/mozilla-central/rev/05d1afda588e54be73e31ef4e022dde91f1ed97a/xpcom/threads/TaskQueue.h#49

Depends on D181965

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: Bug 1840313 fetch and remove the first element of queue in one operation r?#xpcom-reviewers

The two-step logic was left over from a previous std::queue implementation.
https://hg.mozilla.org/mozilla-central/rev/4534179de22c013eb97e8226a538096d7a648721#l2.36

Depends on D181966

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c38028d7b56
remove declaration of non-existent TaskQueue::CancelDelayedRunnables() r=emilio
https://hg.mozilla.org/integration/autoland/rev/3533bb47987a
return full TaskQueue class from CreateBackgroundTaskQueue() r=xpcom-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/e53bf8e2b62a
fetch and remove the first element of queue in one operation r=emilio

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/1c38028d7b56
https://hg.mozilla.org/mozilla-central/rev/3533bb47987a
https://hg.mozilla.org/mozilla-central/rev/e53bf8e2b62a