1840401 - `InvalidStateError ` in `GMPProvider`

Status: NEW

(Core :: Audio/Video: GMP, defect, P3)

Description

[William Durand [:willdurand] (PTO Aug 10-30)]

I see this error in some Try pushes, e.g. https://treeherder.mozilla.org/logviewer?job_id=420640647&repo=try&lineNumber=4074

Exception calling provider GMPProvider.startup: InvalidStateError: Localization.formatValueSync: [fluent] Couldn't find a message: plugins-openh264-name

Stack trace:

buildPluginList()@resource://gre/modules/addons/GMPProvider.sys.mjs:851
startup()@resource://gre/modules/addons/GMPProvider.sys.mjs:721
callProvider()@resource://gre/modules/AddonManager.sys.mjs:228
_startProvider()@resource://gre/modules/AddonManager.sys.mjs:537
registerProvider()@resource://gre/modules/AddonManager.sys.mjs:822
registerProvider()@resource://gre/modules/AddonManager.sys.mjs:3709
observe()@resource://gre/modules/addons/GMPProvider.sys.mjs:876
createBrowserElement()@resource://gre/modules/ExtensionParent.sys.mjs:1378
_do_main()@/builds/worker/workspace/build/tests/xpcshell/head.js:237
_execute_test()@/builds/worker/workspace/build/tests/xpcshell/head.js:584

Comment 1

[William Durand [:willdurand] (PTO Aug 10-30)]

I can reproduce consistently by executing:

mach test toolkit/mozapps/extensions/test/xpcshell/test_shutdown_barriers.js

Comment 2

[Eemeli Aro [:eemeli]]

Could this be related to some oddities of what's done during shutdown, which is what the test seems to be working on? I was able to replicate the error logs locally, and they appear to be independent of which message from which FTL file is being formatted.

Given that the formatting appears to always happen when GMPProvider.sys.mjs is loaded, one workaround here would be to drop the lazy-loading of the Localization instance and apply the formatting at the root level of the module, where it appears to work fine.