Closed Bug 1840546 Opened 2 years ago Closed 5 months ago

Intermittent toolkit/components/places/tests/unit/test_frecency_origins_recalc.js | single tracking bug

Categories

(Toolkit :: Places, defect, P5)

defect

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: intermittent-bug-filer, Assigned: mak)

Details

(Keywords: intermittent-failure, intermittent-testcase)

Attachments

(2 files)

Filed by: ctuns [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=420748498&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/IlkcggqCQJCgjL8gJ4nq4A/runs/0/artifacts/public/logs/live_backing.log


[task 2023-06-27T06:27:32.875Z] 06:27:32     INFO -  TEST-START | toolkit/components/places/tests/unit/test_frecency_origins_recalc.js
[task 2023-06-27T06:27:33.153Z] 06:27:33  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/unit/test_frecency_origins_recalc.js | xpcshell return code: 0
[task 2023-06-27T06:27:33.153Z] 06:27:33     INFO -  TEST-INFO took 269ms
[task 2023-06-27T06:27:33.154Z] 06:27:33     INFO -  >>>>>>>
[task 2023-06-27T06:27:33.155Z] 06:27:33     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2023-06-27T06:27:33.156Z] 06:27:33     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2023-06-27T06:27:33.158Z] 06:27:33     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2023-06-27T06:27:33.159Z] 06:27:33     INFO -  running event loop
[task 2023-06-27T06:27:33.160Z] 06:27:33     INFO -  toolkit/components/places/tests/unit/test_frecency_origins_recalc.js | Starting setup
[task 2023-06-27T06:27:33.160Z] 06:27:33     INFO -  (xpcshell/head.js) | test setup pending (2)
[task 2023-06-27T06:27:33.161Z] 06:27:33     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2023-06-27T06:27:33.162Z] 06:27:33     INFO -  (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2023-06-27T06:27:33.163Z] 06:27:33     INFO -  (xpcshell/head.js) | test setup finished (2)
[task 2023-06-27T06:27:33.164Z] 06:27:33     INFO -  toolkit/components/places/tests/unit/test_frecency_origins_recalc.js | Starting test
[task 2023-06-27T06:27:33.165Z] 06:27:33     INFO -  (xpcshell/head.js) | test test pending (2)
[task 2023-06-27T06:27:33.166Z] 06:27:33     INFO -  (xpcshell/head.js) | test run_next_test 1 finished (2)
[task 2023-06-27T06:27:33.167Z] 06:27:33     INFO -  "CONSOLE_MESSAGE: (info) 1687847253077	places	TRACE	FrecencyRecalculator :: Initializing Frecency Recalculator"
[task 2023-06-27T06:27:33.168Z] 06:27:33     INFO -  "CONSOLE_MESSAGE: (info) 1687847253078	places	TRACE	FrecencyRecalculator :: Arm frecency recalculation"
[task 2023-06-27T06:27:33.168Z] 06:27:33     INFO -  "CONSOLE_MESSAGE: (info) 1687847253079	places	TRACE	FrecencyRecalculator :: Got places-init-complete topic"
[task 2023-06-27T06:27:33.168Z] 06:27:33     INFO -  "CONSOLE_MESSAGE: (info) 1687847253081	places	TRACE	FrecencyRecalculator :: Got frecency-recalculation-needed topic"
[task 2023-06-27T06:27:33.169Z] 06:27:33     INFO -  "CONSOLE_MESSAGE: (info) 1687847253081	places	TRACE	FrecencyRecalculator :: Frecency recalculation requested"
[task 2023-06-27T06:27:33.169Z] 06:27:33     INFO -  "CONSOLE_MESSAGE: (info) 1687847253081	places	TRACE	FrecencyRecalculator :: Arm frecency recalculation"
[task 2023-06-27T06:27:33.169Z] 06:27:33     INFO -  "CONSOLE_MESSAGE: (info) 1687847253083	places	TRACE	FrecencyRecalculator :: Clean up alternative frecency of pages"
[task 2023-06-27T06:27:33.169Z] 06:27:33     INFO -  "CONSOLE_MESSAGE: (info) 1687847253088	places	TRACE	FrecencyRecalculator :: Alternative frecency of origins must be recalculated"
[task 2023-06-27T06:27:33.169Z] 06:27:33     INFO -  "CONSOLE_MESSAGE: (info) 1687847253090	places	TRACE	FrecencyRecalculator :: Recalculate 50 alternative origins frecency values"
[task 2023-06-27T06:27:33.169Z] 06:27:33     INFO -  "CONSOLE_MESSAGE: (info) 1687847253093	places	TRACE	FrecencyRecalculator :: Arm frecency recalculation"
[task 2023-06-27T06:27:33.169Z] 06:27:33     INFO -  TEST-PASS | toolkit/components/places/tests/unit/test_frecency_origins_recalc.js | test - [test : 26] Should have been calculated already - 0 == 0
[task 2023-06-27T06:27:33.171Z] 06:27:33  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/unit/test_frecency_origins_recalc.js | test - [test : 33] Should have been calculated already - 0 == 1
[task 2023-06-27T06:27:33.172Z] 06:27:33     INFO -  /builds/worker/workspace/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_frecency_origins_recalc.js:test:33
[task 2023-06-27T06:27:33.172Z] 06:27:33     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_do_main:237
[task 2023-06-27T06:27:33.172Z] 06:27:33     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:584
[task 2023-06-27T06:27:33.173Z] 06:27:33     INFO -  -e:null:1
[task 2023-06-27T06:27:33.173Z] 06:27:33     INFO -  exiting test
[task 2023-06-27T06:27:33.174Z] 06:27:33     INFO -  Unexpected exception NS_ERROR_ABORT:
[task 2023-06-27T06:27:33.174Z] 06:27:33     INFO -  _abort_failed_test@/builds/worker/workspace/build/tests/xpcshell/head.js:857:20
[task 2023-06-27T06:27:33.175Z] 06:27:33     INFO -  do_report_result@/builds/worker/workspace/build/tests/xpcshell/head.js:966:5
[task 2023-06-27T06:27:33.175Z] 06:27:33     INFO -  Assert<@/builds/worker/workspace/build/tests/xpcshell/head.js:70:21
[task 2023-06-27T06:27:33.176Z] 06:27:33     INFO -  Assert.prototype.report@resource://testing-common/Assert.sys.mjs:240:10
[task 2023-06-27T06:27:33.176Z] 06:27:33     INFO -  equal@resource://testing-common/Assert.sys.mjs:282:8
[task 2023-06-27T06:27:33.176Z] 06:27:33     INFO -  test@/builds/worker/workspace/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_frecency_origins_recalc.js:33:10
[task 2023-06-27T06:27:33.177Z] 06:27:33     INFO -  _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:237:6
[task 2023-06-27T06:27:33.177Z] 06:27:33     INFO -  _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:584:5
[task 2023-06-27T06:27:33.177Z] 06:27:33     INFO -  @-e:1:1
[task 2023-06-27T06:27:33.178Z] 06:27:33     INFO -  exiting test
[task 2023-06-27T06:27:33.178Z] 06:27:33     INFO -  "Force a GC"
[task 2023-06-27T06:27:33.179Z] 06:27:33     INFO -  "CONSOLE_MESSAGE: (info) 1687847253124	places	TRACE	FrecencyRecalculator :: Finalizing frecency recalculator"
[task 2023-06-27T06:27:33.179Z] 06:27:33     INFO -  <<<<<<<
[task 2023-06-27T06:27:33.179Z] 06:27:33     INFO -  TEST-START | security/manager/ssl/tests/unit/test_ct.js
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Status: REOPENED → RESOLVED
Closed: 2 years ago1 year ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Status: REOPENED → RESOLVED
Closed: 1 year ago1 year ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Status: REOPENED → RESOLVED
Closed: 1 year ago10 months ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

As multiple async queries must run, we may end up checking too early for the
expected value.

Assignee: nobody → mak
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/6716d002798d Intermittent test_frecency_origins_recalc.js. r=daisuke,places-reviewers
Status: REOPENED → RESOLVED
Closed: 10 months ago7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch

The issue still persists as it can be seen here

Status: RESOLVED → REOPENED
Flags: needinfo?(mak)
Resolution: FIXED → ---
Target Milestone: 132 Branch → ---

Hm, I wonder if it's set to 1 but then recalculated before the check.

Second try. Restore the test as it was before, but try to disable the
recalculation task until database values are checked.
If this won't be sufficient, we may have to introduce a test-only method to
temporarily pause background updates.

Flags: needinfo?(mak)
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/e3b4ac029935 Intermittent failure in test_frecency_origins_recalc.js. r=daisuke,places-reviewers
Status: REOPENED → RESOLVED
Closed: 7 months ago7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch

This is still happening. The new failure line looks like this: TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/unit/test_frecency_origins_recalc.js | test - [test : 32] Alt frecency should be calculated - 0 == 1

Hi Marco! Can you please take another look at this?
Thank you!

Status: RESOLVED → REOPENED
Flags: needinfo?(mak)
Resolution: FIXED → ---
Target Milestone: 132 Branch → ---

This became extremely infrequent, and that's likely why I had difficulties reproducing on Try. So this is a low priority if it remains at this frequency.
It looks like what we need here is a way to completely disable background recalculation for some time, so there's more time to check status of the database before it changes.

Flags: needinfo?(mak)
Status: REOPENED → RESOLVED
Closed: 7 months ago5 months ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: