1840646 - Pipeline configuration for Glean Contextual Services instrumentation

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P1)

Description

[Chris H-C :chutten]

We treat contextual services data in a special way. We should ensure the Glean-sent data is also treated specially.

Comment 1

[Chris H-C :chutten]

Attachment: pr 4960: bug 1840646 - ACLs for new Glean-sent Contextual Services pings from Desktop

Comment 2

[Chris H-C :chutten]

Attachment: pr 605: bug 1840646 - Apply Contextual Services rules to new top-sites and quick-suggest pings

Comment 3

[Chris H-C :chutten]

whd merged PR #4960: "bug 1840646 - ACLs for new Glean-sent Contextual Services pings from Desktop" in 24ac9b5.

Comment 4

[Chris H-C :chutten]

chutten merged PR #605: "bug 1840646 - Apply Contextual Services rules to new top-sites and quick-suggest pings" in 2cb2d2c.

Comment 5

[Chris H-C :chutten]

And I do believe that's everything needed to make sure everything's tidied away as it should be.

Comment 6

[Wesley Dawson [:whd]]

(In reply to Chris H-C :chutten from comment #3)

whd merged PR #4960: "bug 1840646 - ACLs for new Glean-sent Contextual Services pings from Desktop" in 24ac9b5.

This has been deployed to production.

Comment 7

[Wesley Dawson [:whd]]

While investigating some other issues we noticed that some ios glean apps have been sending topsites impression pings, but that those datasets aren't specially configured: https://github.com/mozilla-services/mozilla-pipeline-schemas/tree/generated-schemas/schemas/org-mozilla-ios-firefox/topsites-impression. Those appear to predate the work here. :chutten, do you think we should be treating the ios glean apps the same way as the other apps sending topsites impression pings?

Comment 8

[Chris H-C :chutten]

I can guarantee that the iOS Glean apps are running zero code shared with the Firefox Desktop or Android topsites implementation, so I'm afraid I have no idea. Travis, do you know who's on Product for Firefox iOS who might know?

Comment 9

[Wesley Dawson [:whd]]

From https://github.com/mozilla-services/cloudops-infra/blob/master/projects/beam/tf/modules/dataflow-jobs/main.tf#L67 it looks like we treat the data from ios similarly to the other applications so it seems likely the schemas are the same and that the underlying data has the same sensitivity. It would be good to verify this though. workgroup:contextual-services is owned by :ckarlof and the group managers are :mreid and :jhollek, so I will speculatively NI them in case they have context here.

Mark or Julie: do you know if the iOS topsites-impression pings should be treated with the same data sensitivity as the contextual-services datasets and other topsites-impression pings?

Comment 10

[Travis Long [:travis_]]

I think Daniella Arcese is the right product person to speak to for Firefox iOS.

Comment 11

[Wesley Dawson [:whd]]

Another case that is possibly related to this: https://github.com/mozilla-services/cloudops-infra/pull/5487#issuecomment-2013918847

Comment 12

[Mark Reid [:mreid]]

Yes, let's apply the same access controls / data sensitivity as we do for these pings from other applications. Thanks!

Comment 13

[Wesley Dawson [:whd]]

https://github.com/mozilla-services/cloudops-infra/pull/5435 which will land today will remove general access to these pings.