1840685 - Crash in [@ mozilla::MediaDecoderStateMachine::LoopingDecodingState::DetermineOriginalDecodedDurationIfNeeded]

Status: RESOLVED DUPLICATE of bug 1826256

(Core :: Audio/Video: Playback, defect)

Description

[Jonathan Brier]

Crash report: https://crash-stats.mozilla.org/report/index/556fe2d6-3164-451c-ac5a-ed6100230627

MOZ_CRASH Reason: MOZ_RELEASE_ASSERT(isSome())

Top 10 frames of crashing thread:

0  libxul.so  mozilla::MediaDecoderStateMachine::LoopingDecodingState::DetermineOriginalDecodedDurationIfNeeded  dom/media/MediaDecoderStateMachine.cpp
1  libxul.so  mozilla::MediaDecoderStateMachine::LoopingDecodingState::HandleEndOfVideo  dom/media/MediaDecoderStateMachine.cpp:1015
2  libxul.so  mozilla::MediaDecoderStateMachine::RequestVideoData const  dom/media/MediaDecoderStateMachine.cpp:3949
2  libxul.so  mozilla::MozPromise<RefPtr<mozilla::VideoData>, mozilla::MediaResult, true>::InvokeMethod<mozilla::MediaDecoderStateMachine::RequestVideoData  xpcom/threads/MozPromise.h:654
2  libxul.so  mozilla::MozPromise<RefPtr<mozilla::VideoData>, mozilla::MediaResult, true>::InvokeCallbackMethod<false, mozilla::MediaDecoderStateMachine::RequestVideoData  xpcom/threads/MozPromise.h:685
2  libxul.so  mozilla::MozPromise<RefPtr<mozilla::VideoData>, mozilla::MediaResult, true>::ThenValue<mozilla::MediaDecoderStateMachine::RequestVideoData  xpcom/threads/MozPromise.h:874
3  libxul.so  mozilla::MozPromise<RefPtr<mozilla::VideoData>, mozilla::MediaResult, true>::ThenValueBase::ResolveOrRejectRunnable::Run  xpcom/threads/MozPromise.h:490
4  libxul.so  mozilla::AutoTaskDispatcher::TaskGroupRunnable::Run  xpcom/threads/TaskDispatcher.h:230
5  libxul.so  mozilla::TaskQueue::Runner::Run  xpcom/threads/TaskQueue.cpp:259
6  libxul.so  nsThreadPool::Run  xpcom/threads/nsThreadPool.cpp:343

Reproducible on Steamdeck Flatpak install by running the WebGL conformance test all/conformance/textures/misc/texture-corner-case-videos.html

Comment 1

[Alastor Wu [:alwu]]

I will take a look on this later.

Comment 2

[BugBot [:suhaib / :marco]]

The bug has a crash signature, thus the bug will be considered confirmed.

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1840685 - set mOriginalDecodedDuration for single track when the track duration is known.

If we seek directly to EOS, it's possible that we still can't know the
track duration because we don't have the last decoded data. Therefore,
we remove the assertion and make it as condition.

Comment 5

[BugBot [:suhaib / :marco]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 6

[Phabricator Automation]

Comment on attachment 9341640 [details]
Bug 1840685 - set mOriginalDecodedDuration for single track when the track duration is known.

Revision D182417 was moved to bug 1826256. Setting attachment 9341640 [details] to obsolete.