1840902 - Make all anti-tracking tests compliant with storage access API grants for secure contexts

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement)

Description

[Harshit Sohaney [:hsohaney]]

Tests within the Anti-tracking component can currently be granted access through the RequestStorageAccess() call. However, the Storage Access API graduation spec states that storage access must only be granted to secure contexts. We have to make our anti-tracking tests compliant with this behaviour.

Comment 1

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1840902 - Adjusted browser chrome tests under the Anti-tracking test suite to support only secure context storage access. r?bvandersloot

Depends on D182366

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8267c9267da
Adjusted browser chrome tests under the Anti-tracking test suite to support only secure context storage access. r=bvandersloot

Comment 3

[Cristian Tuns]

Backed out for causing mochitest failures in automation.py

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-TIMEOUT | automation.py | application timed out after 370 seconds with no output

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db935375566a
Adjusted browser chrome tests under the Anti-tracking test suite to support only secure context storage access. r=bvandersloot

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failure on browser_storageAccessThirdPartyChecks

Backout link: https://hg.mozilla.org/integration/autoland/rev/232191c3ef9861082467fea69f62c9b7fffb3a1c
Log link: https://treeherder.mozilla.org/logviewer?job_id=426055211&repo=autoland&lineNumber=6878

Comment 6

[Harshit Sohaney [:hsohaney]]

(In reply to Narcis Beleuzu [:NarcisB] from comment #5)

Backed out for bc failure on browser_storageAccessThirdPartyChecks

Backout link: https://hg.mozilla.org/integration/autoland/rev/232191c3ef9861082467fea69f62c9b7fffb3a1c
Log link: https://treeherder.mozilla.org/logviewer?job_id=426055211&repo=autoland&lineNumber=6878

Hey, thanks for backing that out. I made an error while pushing to phab and it didnt update! Sorry about that, I'll fix it.

Comment 7

[Narcis Beleuzu [:NarcisB]]

Harshit, please also take a look over those 2 failures:

1. This bc failure on browser_urlbar_keyed_search.js
2. This Mn failure

Comment 8

[Harshit Sohaney [:hsohaney]]

(In reply to Narcis Beleuzu [:NarcisB] from comment #7)

Harshit, please also take a look over those 2 failures:

1. This bc failure on browser_urlbar_keyed_search.js
2. This Mn failure

I have pushed the new patch on try, let me know if these cover the concerned tests
Try Link: https://treeherder.mozilla.org/jobs?repo=try&revision=283058eccc4a17760d81c4bf65af270c4bdaa5d3

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76c2ef9d279a
Adjusted browser chrome tests under the Anti-tracking test suite to support only secure context storage access. r=bvandersloot

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/76c2ef9d279a