184105 - [RFE] Status bar should change when / or ' is pressed

Status: VERIFIED FIXED

(SeaMonkey :: Find In Page, enhancement)

Description

[Owen Marshall (Not reading bugmail)]

I was thinking. The status bar reports when typeahead was sucessful, when it
stops, when it starts with only a key pressed... I thought we should have it
give us a notification when we press one of the accelerator keys. This is the
only time , it seems, when it does not provide notification.

Patch to follow.

Comment 1

[Owen Marshall (Not reading bugmail)]

Attachment: Patch to provide status bar notification when typeahead accelerator is pressed

I have tested this patch against my WinME machine, and it seems to work
properly. As this is my first patch, please pick all the nits you can find =)

Also, if someone could try to apply this patch and test it, I would feel much,
much more confident about it!

Comment 2

[Aaron Leventhal]

Owen, I'm rewriting the way that / and ' work as part of bug 176296, and this
patch conflicts with that. I'll help you do this after I get that patch checked in.

Comment 3

[Owen Marshall (Not reading bugmail)]

Comment on attachment 108606 [details] [diff] [review]
Patch to provide status bar notification when typeahead accelerator is pressed

Not a problem. It wasn't a total waste, as I actually figured out how these
strings work, why you should use nsString instead of nsAString... why using
nsAString will give you compiler errors that keep you
guessing^H^H^H^H^H^H^H^Hworking for hours, etc ;)

Comment 4

[Ariel Arjona]

*** Bug 182539 has been marked as a duplicate of this bug. ***

Comment 5

[Owen Marshall (Not reading bugmail)]

This was fixed by one of aaronl's checkins... which one though?

Comment 6

[sairuh (rarely reading bugmail)]

perhaps as part of bug 176296?

Comment 7

[Owen Marshall (Not reading bugmail)]

Ok, cool. Resolved FIXED (fixed by other checkin)

Comment 8

[sairuh (rarely reading bugmail)]

yep, vrfy'd fixed with 2003.02.10 comm trunk bits on win2k, mac 10.2.3 and linux
rh8.0.

Comment 9

[Owen Marshall (Not reading bugmail)]

*bugspam*