1841193 - Save unnecessary copies in VideoDecoder

Status: RESOLVED FIXED

(Core :: Audio/Video: Web Codecs, enhancement)

Description

[C.M.Chang[:chunmin]]

D182476 in bug 1831451 will add a VideoDecoderConfigInternal class to hold data from VideoDecoderConfig. However, with the changes, description data from VideoDecoderConfig will be copied twice in VideoDecoder::Configure and VideoDecoder::IsConfigSupported (See https://phabricator.services.mozilla.com/D182476?id=737377#inline-1011335).

We should make it copy once

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1841193 - Remove unused variable

Comment 2

[C.M.Chang[:chunmin]]

Attachment: Bug 1841193 - Save unnecessary copy in Configure

Depends on D182533

Comment 3

[C.M.Chang[:chunmin]]

Attachment: Bug 1841193 - Save unnecessary copy in IsConfigSupported

This patch reworks CanDecode(). By making it accept not only
VideoDecoderConfigInternal but also VideoDecoderConfig as its argument,
the description data copied by converting VideoDecoderConfig to
VideoDecoderConfigInternal when checking the decodable information for
the given VideoDecoderConfig can be saved.

Depends on D182534

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af5948aa8a7f
Remove unused variable r=padenot
https://hg.mozilla.org/integration/autoland/rev/da31720ea44f
Save unnecessary copy in Configure r=padenot
https://hg.mozilla.org/integration/autoland/rev/b5482dea9fce
Save unnecessary copy in IsConfigSupported r=padenot

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/af5948aa8a7f
https://hg.mozilla.org/mozilla-central/rev/da31720ea44f
https://hg.mozilla.org/mozilla-central/rev/b5482dea9fce