Closed Bug 1841222 Opened 2 years ago Closed 2 years ago

Incorrect rendering on a codepen demo (https://codepen.io/brownerd/pen/YydvvW)

Categories

(Core :: Graphics: WebRender, defect)

Product:
Core
Component:
Graphics: WebRender
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
117 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox-esr115 --- unaffected
firefox114 --- unaffected
firefox115 --- unaffected
firefox116 --- fixed
firefox117 --- fixed

People

(Reporter: mayankleoboy1, Assigned: gw)

References

(Regression,
URL
)

Details

(Keywords: regression)

Attachments

(5 files)

about:support
40.04 KB, text/plain
Details
bug.png
2.50 MB, image/png
Details
standalone_testcase.html
52.93 KB, text/html
Details
Bug 1841222 - Fix AA on single pixel lines with certain transforms with new mask path
48 bytes, text/x-phabricator-request
Details | Review
0001-Bug-1841222-Fix-AA-on-single-pixel-lines-with-certai.patch
11.01 KB, patch
pascalc
: approval-mozilla-beta+
Details | Diff | Splinter Review

Go to https://codepen.io/brownerd/pen/YydvvW

ER: A circle with radially-outward uniform glow
AR: skewed glow

Regression :
Bug 1836690 - Add support for complex + tiled paths to new clip-mask rendering path r=gfx-reviewers,lsalzman

Attached file about:support —
Attached image bug.png —

Set release status flags based on info from the regressing bug 1836690

:gw, since you are the author of the regressor, bug 1836690, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

status-firefox114: --- → unaffected
status-firefox115: --- → unaffected
status-firefox116: --- → affected
status-firefox-esr102: --- → unaffected
Flags: needinfo?(gwatson)
Severity: -- → S3

Set release status flags based on info from the regressing bug 1836690

status-firefox117: --- → affected
status-firefox-esr115: --- → unaffected

Minimized repro case, with a single div. What seems to be occurring is that the anti-aliasing is failing for a small number of divs on specific angles. In the full test case, there are enough divs present with incorrect AA to show up the overall artifact.

<!DOCTYPE html>
<html lang="en" >
<head>
  <meta charset="UTF-8">
<Style>
body {
  display: flex;
  align-items: center;
  justify-content: center;
  height: 100vh;
  background: #fff;
  width: 100vw;
  transform-origin: 50% 50%;
}
.circle {
  position: relative;
  transform: translateY(-50vw);
}
.deg {
  position: absolute;
  top: 50%;
  left: 50%;
  width: 1px;
  height: 100vw;
  transform: rotateZ(95deg) translate(-50%, 50%);
  transform-origin: 100px;
  background: #333;
}
</Style>



</head>
<body>
<div class="circle">
  <div class="deg"></div>
</div>
</body>
</html>
Assignee: nobody → gwatson
Flags: needinfo?(gwatson)

Minimized wrench test case:

---
root:
  items:
    -
      type: stacking-context
      transform-origin: 200 200
      transform: rotate(45)
      items:
        - type: rect
          bounds: 200 200 1 200
          color: black
Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0d6c6dfecbe9 Fix AA on single pixel lines with certain transforms with new mask path r=gfx-reviewers,lsalzman

https://hg.mozilla.org/mozilla-central/rev/0d6c6dfecbe9

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox117: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch

Fixed in the latest Nightly. Thanks!

See Also: → 1843996

The patch landed in nightly and beta is affected.
:gw, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox116 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(gwatson)

:gw is this okay to ride the 117 train? last beta builds tonight

Comment on attachment 9342967 [details]
Bug 1841222 - Fix AA on single pixel lines with certain transforms with new mask path

Beta/Release Uplift Approval Request

  • User impact if declined: Rendering glitches on some subset of pages (thin lines with transforms).
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small patch, clear fix. It might not graft cleanly on beta, if it doesn't I'll consider whether it's worth rebasing on beta.
  • String changes made/needed:
  • Is Android affected?: Yes
Flags: needinfo?(gwatson)
Attachment #9342967 - Flags: approval-mozilla-beta?

it does not graft cleanly to beta :( if you consider rebasing, let me know if you want this in before we build RC (2023-07-24)

Flags: needinfo?(gwatson)

Here is a rebased patch that applies cleanly for me on mozilla-unified/beta and seems to pass the new tests. Let me know how that goes.

Flags: needinfo?(gwatson) → needinfo?(dsmith)

Comment on attachment 9344972 [details] [diff] [review]
0001-Bug-1841222-Fix-AA-on-single-pixel-lines-with-certai.patch

Approved for the beta branch before the Monday merge and RC, thanks.

Attachment #9344972 - Flags: approval-mozilla-beta+
Attachment #9342967 - Flags: approval-mozilla-beta?
Flags: needinfo?(dsmith)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: