1841317 - WPT failures in css/css-grid/grid-model/grid-container-ignores-first-[letter|line]-* due to failing to target first-letter/first-line in descendant nodes

Status: NEW

(Core :: Layout: Block and Inline, defect)

Description

[Thomas Wisniewski [:twisniewski]]

wpt.fyi:

• https://wpt.fyi/results/css/css-grid/grid-model/grid-container-ignores-first-letter-001.html
• https://wpt.fyi/results/css/css-grid/grid-model/grid-container-ignores-first-line-001.html

These seem to be similar failures, so I'm filing both under one bug.

Comment 1

[Daniel Holbert [:dholbert]]

Some (maybe all?) of this seems to be from us failing to target first-letters in descendant elements.

Reduced testcase:

data:text/html,<style>.c::first-letter{color:green;line-height:200px}</style><div class="c"><div>Nested</div></div><div class="c">Not nested</div>

We don't apply any special styling to the first "N" in "Nested", while Chrome does. (We do apply special styling to the "N" of "Not nested", though.)

Comment 2

[Daniel Holbert [:dholbert]]

(The actual WPT test has a grid container as a previous-sibling of the block container element, and the test is skipping that we ignore the grid. But we're not hitting the nested block at all with our first-letter styling, regardless of whether the grid is there.)

Comment 4

[Daniel Holbert [:dholbert]]

These WPTs (from bug 1841318) are all the same underlying issue:
https://wpt.fyi/results/css/css-grid/grid-model/grid-first-letter-003.html
https://wpt.fyi/results/css/css-grid/grid-model/grid-first-line-003.html
https://wpt.fyi/results/css/css-grid/grid-model/grid-inline-first-letter-003.html
https://wpt.fyi/results/css/css-grid/grid-model/grid-inline-first-line-003.html

Comment 5

[Emilio Cobos Álvarez (:emilio)]

That is bug 317081

Comment 6

[Daniel Holbert [:dholbert]]

Indeed, thanks! Marking as depending on that bug (though it's sorta a dupe I guess).

Comment 7

[Daniel Holbert [:dholbert]]

It looks like that bug is dependent on bug 1465474 which has some WIP work but it looks pretty substantial and non-trivial.

Definitely something we should fix when we have cycles, but it's entirely unrelated to grid. Possibly we should split out the actually grid-relevant parts here (the grid container ignoring these pseudos, and display:block grid items honoring them) from the unrelated-to-grid parts (the bug 317081 parts, RE the pseudos applying recursively to the first child of the block that they're specified on). And that latter part is definitely interesting to test, but seems like a stretch as being part of a "grid interop" focus area.

Comment 8

[Daniel Holbert [:dholbert]]

ni=me to push on comment 7.

Comment 9

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #4)

These WPTs (from bug 1841318) are all the same underlying issue:
https://wpt.fyi/results/css/css-grid/grid-model/grid-first-letter-003.html
https://wpt.fyi/results/css/css-grid/grid-model/grid-first-line-003.html
https://wpt.fyi/results/css/css-grid/grid-model/grid-inline-first-letter-003.html
https://wpt.fyi/results/css/css-grid/grid-model/grid-inline-first-line-003.html

I've un-duped bug 1841318 to fix up these tests, so that they don't trip over bug 317081.

I think the tests in comment 0 here are testing something slightly different.