1841428 - Intermittent dom/base/test/fullscreen/test_fullscreen_modal.html | single tracking bug

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: ctuns [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=421285374&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/ayNUVo1KRdqpDRl1pg-jJw/runs/0/artifacts/public/logs/live_backing.log

---

[task 2023-07-02T09:57:02.941Z] 09:57:02     INFO - TEST-PASS | dom/base/test/fullscreen/test_fullscreen_modal.html | Should be transitioning to fullscreen 
[task 2023-07-02T09:57:02.941Z] 09:57:02     INFO - Buffered messages finished
[task 2023-07-02T09:57:02.941Z] 09:57:02     INFO - TEST-UNEXPECTED-FAIL | dom/base/test/fullscreen/test_fullscreen_modal.html | Test timed out. - 
[task 2023-07-02T09:57:03.907Z] 09:57:03     INFO - GECKO(7452) | MEMORY STAT | vsize 6734MB | residentFast 130MB | heapAllocated 7MB
[task 2023-07-02T09:57:03.919Z] 09:57:03     INFO - TEST-OK | dom/base/test/fullscreen/test_fullscreen_modal.html | took 322486ms
[task 2023-07-02T09:57:07.029Z] 09:57:07     INFO - Error: Unable to restore focus, expect failures and timeouts.
[task 2023-07-02T09:57:07.056Z] 09:57:07     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-07-02T09:57:07.056Z] 09:57:07     INFO - TEST-UNEXPECTED-FAIL | dom/base/test/fullscreen/test_fullscreen_modal.html | TypeError: Fullscreen request aborted - Should not throw any errors
[task 2023-07-02T09:57:07.056Z] 09:57:07     INFO -     add_task/nextTick/<@SimpleTest/SimpleTest.js:2165:26
[task 2023-07-02T09:57:07.056Z] 09:57:07     INFO -     async*nextTick@SimpleTest/SimpleTest.js:2182:11
[task 2023-07-02T09:57:07.056Z] 09:57:07     INFO -     setTimeout handler*SimpleTest_setTimeoutShim@SimpleTest/SimpleTest.js:920:41
[task 2023-07-02T09:57:07.057Z] 09:57:07     INFO -     add_task@SimpleTest/SimpleTest.js:2096:17
[task 2023-07-02T09:57:07.057Z] 09:57:07     INFO -     @dom/base/test/fullscreen/test_fullscreen_modal.html?currentTestURL=dom%2Fbase%2Ftest%2Ffullscreen%2Ftest_fullscreen_modal.html&closeWhenDone=1&showTestReport=false&expected=pass:65:9
[task 2023-07-02T09:57:07.057Z] 09:57:07    ERROR - TEST-UNEXPECTED-FAIL | SimpleTest | this test already called finish!
[task 2023-07-02T09:57:07.092Z] 09:57:07     INFO - GECKO(7452) | [Parent 7452, Main Thread] WARNING: Received `load` event on unbridged BrowserParent!: file /builds/worker/checkouts/gecko/dom/ipc/BrowserParent.cpp:4016
[task 2023-07-02T09:57:07.092Z] 09:57:07     INFO - GECKO(7452) | [Parent 7452, Main Thread] WARNING: Received `load` event on unbridged BrowserParent!: file /builds/worker/checkouts/gecko/dom/ipc/BrowserParent.cpp:4016
[task 2023-07-02T09:57:07.095Z] 09:57:07    ERROR - addAssertionCount should only be called by a cross origin test
[task 2023-07-02T09:57:07.096Z] 09:57:07     INFO - TEST-UNEXPECTED-ERROR | dom/base/test/fullscreen/test_fullscreen_modal.html | called finish() multiple times
[task 2023-07-02T09:57:07.096Z] 09:57:07     INFO - TEST-INFO 
[task 2023-07-02T09:57:07.099Z] 09:57:07     INFO - GECKO(7452) | [Child 7464, Main Thread] WARNING: IPC message 'PContent::Msg_StoreUserInteractionAsPermission' discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:508
[task 2023-07-02T09:57:07.100Z] 09:57:07     INFO - GECKO(7452) | [Child 7464, Main Thread] WARNING: nsAppShell::Exit() called redundantly: file /builds/worker/checkouts/gecko/widget/cocoa/nsAppShell.mm:861
[task 2023-07-02T09:57:07.205Z] 09:57:07     INFO - GECKO(7452) | [Parent 7452, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/netwerk/dns/nsEffectiveTLDService.cpp:234
[task 2023-07-02T09:57:07.206Z] 09:57:07     INFO - GECKO(7452) | [Parent 7452, Main Thread] WARNING: 'NS_FAILED(rv)', file /builds/worker/checkouts/gecko/toolkit/components/antitracking/AntiTrackingUtils.cpp:517
[task 2023-07-02T09:57:07.212Z] 09:57:07     INFO - TEST-START | Shutdown

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:bradwerth, since you are the author of the regressor, bug 1827202, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Brad Werth [:bradwerth]]

Hmmm... thought we had this one figured in Bug 1827202. I'll take another look.

Comment 3

[Intermittent Failures Robot]

1 failures in 3594 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform and build breakdown:

• macosx1015-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1841428&startday=2023-06-26&endday=2023-07-02&tree=all

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1827202

Comment 5

[Intermittent Failures Robot]

1 failures in 2956 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform and build breakdown:

• macosx1015-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1841428&startday=2023-07-03&endday=2023-07-09&tree=all

Comment 6

[Intermittent Failures Robot]

1 failures in 2218 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• macosx1015-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1841428&startday=2023-08-21&endday=2023-08-27&tree=all

Comment 7

[Intermittent Failures Robot]

3 failures in 3019 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1
• autoland: 2

Platform and build breakdown:

• macosx1015-64-shippable-qr: 1
  • opt: 1
• macosx1015-64-qr: 2
  • debug: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1841428&startday=2023-08-28&endday=2023-09-03&tree=all

Comment 8

[Intermittent Failures Robot]

1 failures in 3850 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• macosx1015-64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1841428&startday=2023-09-18&endday=2023-09-24&tree=all

Comment 9

[Intermittent Failures Robot]

2 failures in 3764 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 2

Platform and build breakdown:

• macosx1015-64-qr: 1
  • debug: 1
• macosx1015-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1841428&startday=2023-10-09&endday=2023-10-15&tree=all

Comment 10

[Intermittent Failures Robot]

2 failures in 3484 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1
• autoland: 1

Platform and build breakdown:

• macosx1015-64-qr: 2
  • debug: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1841428&startday=2023-10-16&endday=2023-10-22&tree=all

Comment 11

[Intermittent Failures Robot]

1 failures in 3356 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform and build breakdown:

• macosx1015-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1841428&startday=2023-10-30&endday=2023-11-05&tree=all

Comment 12

[Intermittent Failures Robot]

1 failures in 3288 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• macosx1015-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1841428&startday=2023-11-06&endday=2023-11-12&tree=all

Comment 13

[Intermittent Failures Robot]

1 failures in 3495 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• macosx1015-64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1841428&startday=2023-11-13&endday=2023-11-19&tree=all

Comment 14

[Brad Werth [:bradwerth]]

Looking again to try to fixup the test definitively. It's hard. The error log gives us "Fullscreen request denied" which comes from https://searchfox.org/mozilla-central/rev/877adfeec838cdad97369441865bac605109427d/dom/base/FullscreenChange.h#106, but it doesn't output whichever of the many reasons for rejection. Since those are internal error enums representing an implementation detail, it's hard to justify exposing them to JS. Best guess is that this is another instance of FullscreenDeniedNotFocusedTab, but it's hard to know how to force the browsing context to be topmost, which is what causes this rejection. Options:

1. Try the request N times with a delay until it succeeds, swallowing the intermediate rejections.
2. Do more to force the browsing context to be topmost. Apparently fullscreenElement.focus(); is not sufficient.

I'll see if I can get either one of those to look nice in the context of this test. It's really a shame that our fullscreen stuff is so timing dependent, because the fullscreen API resolves promises when the fullscreen transition begins, not when it ends.

Comment 15

[Intermittent Failures Robot]

1 failures in 4108 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• macosx1015-64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1841428&startday=2023-11-27&endday=2023-12-03&tree=all

Comment 16

[Intermittent Failures Robot]

1 failures in 3671 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform and build breakdown:

• macosx1015-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1841428&startday=2023-12-04&endday=2023-12-10&tree=all

Comment 17

[Intermittent Failures Robot]

1 failures in 3349 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform and build breakdown:

• macosx1015-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1841428&startday=2023-12-18&endday=2023-12-24&tree=all

Comment 18

[Intermittent Failures Robot]

1 failures in 1162 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• macosx1015-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1841428&startday=2023-12-25&endday=2023-12-31&tree=all

Comment 19

[BugBot [:suhaib / :marco/ :calixte]]

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit BugBot documentation.

Comment 20

[Treeherder Bug Filer]

New failure instance: https://treeherder.mozilla.org/logviewer?job_id=447867190&repo=mozilla-beta

Comment 21

[Intermittent Failures Robot]

1 failures in 3382 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform and build breakdown:

• macosx1015-64-devedition-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1841428&startday=2024-02-19&endday=2024-02-25&tree=all

Comment 22

[Brad Werth [:bradwerth]]

The most recent failure shows that document.exitFullscreen() is getting dropped. There are multiple early exits that could cause this...

In RestorePreviousFullscreenState:

• No active window. Probably impossible since the document had a window when it entered fullscreen.
• Not in fullscreen mode. Not this. The test checks that there is a fullscreen element.

In SetFullscreenInternal:

• Some confusion about whether we are in DOM fullscreen or window fullscreen. Not this. The logic should keep this from mattering since exiting fullscreen is allowed for both cases.
• If we're still in a fullscreen processing request. This is at least possible since we just entered fullscreen and awaiting the promise is not really a signifier that the internal fullscreen state has caught up.

So the fix will be adding a wait on some signal that the fullscreen enter request is all the way done. I'm still not sure what the last signal is in the fullscreen transition. Many other fullscreen tests choose to wait on the browsing context becoming active again. That works in those tests; that's what I'll add here.

Comment 23

[Brad Werth [:bradwerth]]

Attachment: Bug 1841428: In test_fullscreen_modal, ensure document is active before trying to exit fullscreen.

This change checks that the interal fullscreen state is sensible before
trying to exit fullscreen. Awaiting the requestFullscreen promise is not
sufficient.

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17158d000a76
In test_fullscreen_modal, ensure document is active before trying to exit fullscreen. r=edgar

Comment 25

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/17158d000a76

Comment 26

[Intermittent Failures Robot]

7 failures in 4052 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 2
• mozilla-beta: 5

Platform and build breakdown:

• macosx1015-64-shippable-qr: 5
  • opt: 5
• macosx1015-64-devedition-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1841428&startday=2024-02-26&endday=2024-03-03&tree=all

Comment 27

[Intermittent Failures Robot]

2 failures in 4198 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 2

Platform and build breakdown:

• macosx1015-64-devedition-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1841428&startday=2024-03-04&endday=2024-03-10&tree=all