1841429 - Firefox 115 Bookmark Toolbar - Firefox connects(preload) with a right click to web page

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Maddi]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

Firefox 115.0-candidates
Debian Stable Gnome Wayland

Open a Terminal with env MOZ_ENABLE_WAYLAND=1 ...
Tab with about:networking

Bookmark Toolbar "Always Show" and right click on a bookmark.
I only want to delete the bookmark (with website: https://tracker.debian.org/pkg/firefox-esr).
In my case it tries to open the encrypted password manager directly after the right clicking.

Actual results:

Now you can see in about:networking Firefox preloads directly the website.

Expected results:

Firefox should not connect to the website when I click right on the bookmark toolbar.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Alice0775 White]

I can reproduce this on Windows10 (but no need MOZ_ENABLE_WAYLAND=1).

Comment 3

[Alice0775 White]

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9fd81f089c484ee7d36366d6363613fd2c0d57d9&tochange=927d2a569717f2dcb16d748468a880749cfe03df

Suspect:
f9ab66e133a3df138dbac6d39a1743ac24ab4fda Evgenia Kotovich — Bug 1355460 - Speculatively connect toolbar & menu to bookmarked site on mousedown. r=mak

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1355460

Comment 5

[Marco Bonardo [:mak]]

The preloading is done on purpose to speed up loading the page, it can be disabled setting browser.places.speculativeConnect.enabled to false in about:config

Is this actually causing a password manager to be shown on your system?

Comment 6

[Marco Bonardo [:mak]]

Not a regression.

Comment 7

[Marco Bonardo [:mak]]

We could probably limit to left mouse button, it would be nice on the context menu open options too, but not sure it's worth the complexity

Comment 8

[Maddi]

Is this actually causing a password manager to be shown on your system?

In combination with this page as a bookmark in the adress bar e.g. https://tracker.debian.org/pkg/firefox-esr
But it seems to happen on a few other websites as well.

The password dialog is displayed on tracker.debian.org , although no passwords are stored
https://bugzilla.mozilla.org/show_bug.cgi?id=1799276

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mak, could you have a look please?

For more information, please visit BugBot documentation.

Comment 10

[Moritz Beier [:mbeier]]

Attachment: Bug 1841429 - Firefox 115 Bookmark Toolbar - Firefox connects(preload) with a right click to web page. r?#places-reviewers

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e86807cd0b99
Firefox 115 Bookmark Toolbar - Firefox connects(preload) with a right click to web page. r=places-reviewers,mak

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e86807cd0b99