1841489 - Add various missing tests for unified toolbar

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, task)

Description

[Martin Giger [:freaktechnik]]

+++ This bug was initially created as a clone of Bug #1816435 +++

During the implementation of the unified toolbar the emphasis was on creating the new infrastructure, with tests often falling behind. This task will rectify this situation and ensure the unified toolbar is covered in tests wherever possible. A few spotlight areas that need tests:

• Most of the customization is untested. This includes the various customization verbs.
  • Needs tests around visibility of window features, so only customization and titlebar are visible
• All the widgets we show inside the toolbar are untested. We should have tests for every widget
• There were some bug fixes to tab hiding, we should test the fixed behavior
• We should have some large integration tests that test the behavior from customizing to add items to the toolbar changing based on the space to executing an action in the toolbar
• Tests that ensure window decorations are always visible

This is a continuation of the above.

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: Bug 1841489 - Add integration tests for unified toolbar. r=#thunderbird-reviewers

Comment 2

[Martin Giger [:freaktechnik]]

Attachment: Bug 1841489 - Add unified toolbar customization integration tests. r=#thunderbird-reviewers

Depends on D182667

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d75cc401aadc
Add integration tests for unified toolbar. r=aleca
https://hg.mozilla.org/comm-central/rev/a2ca0f0cf816
Add unified toolbar customization integration tests. r=aleca

Comment 4

[Martin Giger [:freaktechnik]]

Attachment: Bug 1841489 - Handle scroll in unified toolbar customization. r=#thunderbird-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e3db471d0e0b
Handle scroll in unified toolbar customization. r=elizabeth

Comment 6

[Martin Giger [:freaktechnik]]

Attachment: Bug 1841489 - Add test to ensure window controls are always visible in unified toolbar. r=#thunderbird-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6f4c16240168
Add test to ensure window controls are always visible in unified toolbar. r=aleca