Closed Bug 1841577 Opened 2 years ago Closed 2 years ago

Don't set WEBRTC_ENABLE_AVX2 on platforms that don't have AVX2

Categories

(Core :: WebRTC, task)

Product:
Core
Component:
WebRTC
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
117 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- fixed
firefox117 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(2 files)

Bug 1841577 - Don't set WEBRTC_ENABLE_AVX2 on platforms that don't have AVX2.
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-esr115+
Details | Review
Bug 1841577 - Don't set WEBRTC_ENABLE_AVX2 on platforms that don't have AVX2 (moz.build refresh).
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-esr115+
Details | Review
No description provided.
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Blocks: 1841585
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/427a997838df Don't set WEBRTC_ENABLE_AVX2 on platforms that don't have AVX2. r=mjf,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/a78fb9a4181c Don't set WEBRTC_ENABLE_AVX2 on platforms that don't have AVX2 (moz.build refresh). r=mjf,webrtc-reviewers

Backed out for causing merge conflicts.
Backout link: https://hg.mozilla.org/integration/autoland/rev/c5eae0db73f838c961da3e9ed3758c4ddf46c35c

Flags: needinfo?(mh+mozilla)
Flags: needinfo?(mh+mozilla)
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/46fb51c90709 Don't set WEBRTC_ENABLE_AVX2 on platforms that don't have AVX2. r=mjf,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/c53e31154478 Don't set WEBRTC_ENABLE_AVX2 on platforms that don't have AVX2 (moz.build refresh). r=mjf,webrtc-reviewers

https://hg.mozilla.org/mozilla-central/rev/46fb51c90709
https://hg.mozilla.org/mozilla-central/rev/c53e31154478

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox117: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch

Comment on attachment 9342169 [details]
Bug 1841577 - Don't set WEBRTC_ENABLE_AVX2 on platforms that don't have AVX2.

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Preliminary patch for bug 1841585
  • User impact if declined: N/A
  • Fix Landed on Version: 117
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Practically speaking this is a no-op patch: it unsets a define that isn't used on the platforms it's removed for.
Attachment #9342169 - Flags: approval-mozilla-esr115?
Attachment #9342484 - Flags: approval-mozilla-esr115?

Comment on attachment 9342169 [details]
Bug 1841577 - Don't set WEBRTC_ENABLE_AVX2 on platforms that don't have AVX2.

Approved for 115.1esr.

Attachment #9342169 - Flags: approval-mozilla-esr115? → approval-mozilla-esr115+
Attachment #9342484 - Flags: approval-mozilla-esr115? → approval-mozilla-esr115+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: