1841585 - Failure to build with --enable-webrtc on MIPS

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Mike Hommey [:glandium]]

(--enable-webrtc is currently the default, and has actually been broken for a long time)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1841585 - Simplify webrtc_default.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1841585 - Disable webrtc by default on MIPS.

It has been broken for a long time, and while following changes are
going to fix that, that will also require a differently set default.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1841585 - Generate webrtc moz.build snippets for mipsel and mips64el.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1841585 - Re-enable webrtc by default on little endian mips*.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1841585 - Generate webrtc moz.build snippets for mipsel and mips64el (moz.build refresh).

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b0ecb6aff8f
Simplify webrtc_default. r=firefox-build-system-reviewers,sergesanspaille
https://hg.mozilla.org/integration/autoland/rev/77204d6a6ee9
Disable webrtc by default on MIPS. r=webrtc-reviewers,mjf
https://hg.mozilla.org/integration/autoland/rev/544449066346
Generate webrtc moz.build snippets for mipsel and mips64el. r=webrtc-reviewers,mjf
https://hg.mozilla.org/integration/autoland/rev/b4d732c8d064
Generate webrtc moz.build snippets for mipsel and mips64el (moz.build refresh). r=webrtc-reviewers,mjf
https://hg.mozilla.org/integration/autoland/rev/c30c8bf23c11
Re-enable webrtc by default on little endian mips*. r=webrtc-reviewers,mjf

Comment 7

[Atila Butkovits]

Backed out for causing merge conflicts.
Backout link: https://hg.mozilla.org/integration/autoland/rev/8cb3ce82f1bd57bc47df8bf9238e28b57e70085c

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f8e2c22bb99
Simplify webrtc_default. r=firefox-build-system-reviewers,sergesanspaille
https://hg.mozilla.org/integration/autoland/rev/763cb19b92c6
Disable webrtc by default on MIPS. r=webrtc-reviewers,mjf
https://hg.mozilla.org/integration/autoland/rev/a1d94640cb00
Generate webrtc moz.build snippets for mipsel and mips64el. r=webrtc-reviewers,mjf
https://hg.mozilla.org/integration/autoland/rev/d2a82695cf31
Generate webrtc moz.build snippets for mipsel and mips64el (moz.build refresh). r=webrtc-reviewers,mjf
https://hg.mozilla.org/integration/autoland/rev/7c42ae8a8e6c
Re-enable webrtc by default on little endian mips*. r=webrtc-reviewers,mjf

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/9f8e2c22bb99
https://hg.mozilla.org/mozilla-central/rev/763cb19b92c6
https://hg.mozilla.org/mozilla-central/rev/a1d94640cb00
https://hg.mozilla.org/mozilla-central/rev/d2a82695cf31
https://hg.mozilla.org/mozilla-central/rev/7c42ae8a8e6c

Comment 10

[Mike Hommey [:glandium]]

Comment on attachment 9342177 [details]
Bug 1841585 - Simplify webrtc_default.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Build failure for mips linux
• User impact if declined: See above
• Fix Landed on Version: 117
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): NPOTB

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9342177 [details]
Bug 1841585 - Simplify webrtc_default.

Approved for 115.1esr.

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/34c70fc94018
https://hg.mozilla.org/releases/mozilla-esr115/rev/8fc8c9e2ac93
https://hg.mozilla.org/releases/mozilla-esr115/rev/7ecb078a404b
https://hg.mozilla.org/releases/mozilla-esr115/rev/4cf189a3e9f5
https://hg.mozilla.org/releases/mozilla-esr115/rev/74714b3781b9