1841677 - WPT failures in css/css-grid/grid-definition with repeat(auto-fill/auto-fit, ...)

Status: RESOLVED FIXED

(Core :: Layout: Grid, defect, P3)

Description

[Thomas Wisniewski [:twisniewski]]

These WPTs seem to be failing due to us apparently not handing CSS like this: repeat(auto-fill, 50px), or repeat(auto-fit, minmax(50px, 25px)) as the tests expect;

• https://wpt.fyi/results/css/css-grid/grid-definition/grid-auto-fill-columns-001.html
• https://wpt.fyi/results/css/css-grid/grid-definition/grid-auto-fill-rows-001.html
• https://wpt.fyi/results/css/css-grid/grid-definition/grid-auto-fit-columns-001.html
• https://wpt.fyi/results/css/css-grid/grid-definition/grid-auto-fit-rows-001.html

These also seem potentially related:

• https://wpt.fyi/results/css/css-grid/grid-definition/grid-auto-repeat-max-size-002.html
• https://wpt.fyi/results/css/css-grid/grid-definition/grid-auto-repeat-min-size-004.html
• https://wpt.fyi/results/css/css-grid/grid-definition/grid-auto-repeat-min-size-004.html
• https://wpt.fyi/results/css/css-grid/grid-definition/grid-auto-repeat-minmax.html
• https://wpt.fyi/results/css/css-grid/grid-definition/grid-repeat-max-width-001.html
• https://wpt.fyi/results/css/css-grid/grid-definition/grid-auto-repeat-dynamic-001.html
• https://wpt.fyi/results/css/css-grid/grid-definition/grid-auto-repeat-dynamic-003.html *

• this one might also be related to aspect ratio issues, as in bug 1740236

I wonder if this is because of bug 1632578?

Comment 1

[Boris Chiou [:boris]]

I suspect some of the test failures might be related to Bug 1865438.

Comment 2

[Emily McDonough [:alaskanemily]]

The first 4 plus grid-auto-repeat-minmax.html are all caused by us not measuring repeat(.., minmax) where max < min correctly.

The others might actually be parsing or serialization related, but I'm unsure (I will be looking into them once the minmax fix is done). Definitely a different cause.

Comment 3

[Emily McDonough [:alaskanemily]]

Attachment: Bug 1841677 - Fix incorrect flooring of grid auto-repeat with minmax(.., ..)) when max < min

This was already happening correctly when placing grid items, but it was not
implemented correctly when measuring the overal grid size.

Ideally, MaxSizingFor or some kind of replacement could do this kind of check
already. If you don't want to fiddle around with sizing functions then you
probably want to perform this check every time, and if you really need the
max sizing function directly you can just get it with SizingFor.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9624ffc06a9
Fix incorrect flooring of grid auto-repeat with minmax(.., ..)) when max < min r=dholbert

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f9624ffc06a9