1841681 - [wpt-sync] Sync PR 40876 - VT: Use a layout object walk with visibility checks for overflow.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 40876 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40876
Details from upstream follow.

Vladimir Levin <[e-mail]> wrote:

VT: Use a layout object walk with visibility checks for overflow.

Our current walk uses paint layers, which is faster but will miss cases
where visibility changes on non-paintlayer children.

The new walk is visually correct in visibility cases, but may be slower.
The new walk is enabled by default but is gated by a killswitch flag.

R=[e-mail], [e-mail]

Bug: 1458568
Change-Id: I4987acb8fb0d5f808a4d1a2ffa549c8f33ba42e0
Reviewed-on: https://chromium-review.googlesource.com/4664920
WPT-Export-Revision: 3af8322158af535943f4006fe55a51fb596dd1d4

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e944f5a353749232c719bb6fbc10746503607768

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

TIMEOUT: 3

Chrome

PASS : 1
FAIL : 2

Safari

TIMEOUT: 3

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-view-transitions/capture-with-opacity-zero-child.html [wpt.fyi]: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /css/css-view-transitions/capture-with-visibility-hidden-child.html [wpt.fyi]: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
• /css/css-view-transitions/capture-with-visibility-mixed-descendants.html [wpt.fyi]: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2cfb8713c0b
[wpt PR 40876] - VT: Use a layout object walk with visibility checks for overflow., a=testonly
https://hg.mozilla.org/integration/autoland/rev/53f37c815bfa
[wpt PR 40876] - Update wpt metadata, a=testonly

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d2cfb8713c0b
https://hg.mozilla.org/mozilla-central/rev/53f37c815bfa