184169 - resizer appears unthemed, when it shouldn't appear at all

Status: VERIFIED FIXED

(Core Graveyard :: Skinability, defect)

Description

[Michael Lefevre]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3a) Gecko/20021207
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3a) Gecko/20021207

in the bottom right of the window, a resizer appears.  sticks out particularly
in modern theme, as it's a native windows resizer and not in the themed colour.
appeared since December 3.

following discussion on IRC, I understand this a result of:
http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/bindings/general.xml#226


Reproducible: Always

Steps to Reproduce:
1. just load mozilla
Actual Results:  
resizer is present

Expected Results:  
resizer should not show, or should be styled in keeping with the theme

Comment 1

[Michael Lefevre]

Attachment: screenshot showing incorrect resizer

Comment 2

[Michael Lefevre]

Attachment: screenshot showing no resizer

how it should look - screenshot from a build from last week

thanks to jesus_x for the screenshots

Comment 3

[Grey Hodge (jX)]

Actually, since the main goal of Mozilla is to increase the entropy of the
universe, why not leave a grippy thing there, just theme it? I can supply a PNG
to apply over a theme-able corner color area.

Comment 4

[Grey Hodge (jX)]

Attachment: PNG Grippy, as promised.

It's the exact size of the corner, so no need to do too much positioning or
anything, just stick it in. 24bit PNG with two colors, and 3 transparency
levels (100%, 50% and 0%) for the proper effect when themed.

Comment 5

[Tim Hill]

Attachment: Patch to statusbar binding, modern, classic

This isn't a bug, this was part of my master plan to slowly morph Modern into
Classic so we could eliminate Modern from the tree ;)  Oh alright, here's a
patch (I can't believe Hyatt used an inline style attribute).  The graphic
should be added as themes/modern/global/icons/resizer.png

Comment 6

[Boris Zbarsky [:bzbarsky]]

to tim

Comment 7

[jag (Peter Annema)]

Comment on attachment 109621 [details] [diff] [review]
Patch to statusbar binding, modern, classic

r=jag

Comment 8

[Boris Zbarsky [:bzbarsky]]

patch checked in (image checked in too).

Comment 9

[Grey Hodge (jX)]

Marking Fixed. Shows up in 2003010508

Comment 10

[Greg K.]

Does this bug, after all, have anything to do with bug 30579, which it blocks?

Comment 11

[Boris Zbarsky [:bzbarsky]]

Yes.  Until this was fixed it was impossible to adequately debug bug 30579

Comment 12

[Michael Lefevre]

coolness - resizer is themed again (2002010508/win2k)

verified fixed.

Comment 13

[Ben Ruppel]

Okay, unless I'm delirious, modern theme had had the resizer in WinXP earlier
than december, PLUS the graphic matched the native XP resizer (a bunch of dots
instead of diagonal lines).  

Looks like this patch may have caused a regression.  

Comment 14

[Grey Hodge (jX)]

To be clear, the "native" XP resizer you're speaking about is actually the Luna
Visual Style's resizer, which is different from the Windows Classic Visual Style
resizer, which is what we have here. This is why WinXP is such a PITA with this
new Luna crap - <rant interrupted>. We may need to check for what VS is used,
like we do for other features, such as scrollbars, form controls, etc. Ugh.

Comment 15

[Boris Zbarsky [:bzbarsky]]

Um.. We're talking about the _modern_ theme here.  Is that also matching the
visual style?  I would have thought that would be restricted to the Classic theme?

Comment 16

[Grey Hodge (jX)]

Yeah, actually that's right. Modern was where this bug was supposed to target,
but the patch addresses both classic AND modern. I suppose making Classic obey
Visual Styles (when differing from the Windows Classic style) should be a
separate bug. 

Comment 17

[Ben Ruppel]

Okay, I was talking about modern.  The situation is this: in Windows XP, using
the Luna theme, modern theme used to follow the native theme, resulting in the
dots instead of the lines.  Now it is showing the lines. 

One could say that modern is not supposed to follow the native theme, and
therefore it can use whatever graphic you so choose.  However, modern used to
follow the native theme more closely, and now it doesn't.  I was under the
impression that it was a little harder to redefine what the theme should look
like.  Harder, in any case, than inadvertantly changing a basic component with a
checkin and then going back and saying "well, it's supposed to be that way."

Comment 18

[Boris Zbarsky [:bzbarsky]]

> One could say that modern is not supposed to follow the native theme

And one would be absolutely correct.  Modern is supposed to look like Modern. 
Before this checkin it all looked like Modern, except for one corner, which
looked like whatever the native theme happened to look like.  In your case, this
seems to have blended in nicely with Modern; for other people it did not.

This brings us to the basic issue -- one either uses system colors (and by
"system colors" I mean "system colors and system-colored widgets", but I am too
lazy to type it every time) for _everything_ or for nothing.  Middle ground is
unacceptable, because some user's choice of system colors will clash with your
non-system colors.  So Mozilla ships with two themes -- Classic, which uses
system colors, and Modern, which does not.

This checkin did not redefine anything; it just fixed a bug.  The bug was that
Modern was using a system color, which it should never do.

No one is trying to pull a fast one here; a brief look at the first screenshot
posted in this bug wil show exactly why the pre-checkin state of things was
completely unacceptable.

Now if we had a way to guess when the system color would not clash with the
current theme and use it in those cases, that would be great.  If you have ideas
on accomplishing this, please file a bug on it.  ;)

Comment 19

[Ben Ruppel]

I'm sorry, I'm talking about a static graphic for modern here.  The grippy in
modern, in windows xp never followed system colors, it only followed the system
graphic (unless something weird was happening for a week or so and I missed it).  

How does the bunch of dots in the lower corner of modern have to follow any
system colors at all?  It is a part of modern, so it can always have a blue
background.  Just use dots instead of lines.  That first screenshot shows a
state that never used to show up in winxp with luna and modern.

Comment 20

[Boris Zbarsky [:bzbarsky]]

> The grippy in modern, in windows xp never followed system colors, it only
> followed the system graphic

That is exactly the same thing.  Read my definition of system colors again,
please.  Graphic, color -- it has the same color-matching problem.

The first screenshot would be the state if you used the non-Luna visual style in
WinXP.... Like I said, if you want us to use the system colors/graphics when and
only when they match the current theme, that would be a great idea for a PhD
thesis...

Comment 21

[Ben Ruppel]

It's a graphic that's defined by modern.  The color doesn't have to change
whether the OS is luna or classic themed.  The modern status bar will always
have a blue background.  You just have to make it so the blue dotty graphic
shows up instead of the lines.

I can't confirm if the classic winxp theme has the dots or lines, but I believe
that it does.  If it does not, then I see your issue.  If it does, doesn't the
mozilla classic theme already track whether you're in luna or classic OS theme?

Comment 22

[Boris Zbarsky [:bzbarsky]]

No, Classic does not track which visual style you use.  It just asks the OS,
"paint a resizer here".  And the OS does it.  So it looks like the current OS
visual style.  For Modern, what you're asking to do is to have us paint the OS
resizer somewhere but in the Modern colors, basically (and Classic Windows
(pre-XP) resizers have the lines, btw; never used XP, so don't know about that one).

Comment 23

[Grey Hodge (jX)]

XP Under Luna has the dots. XP with the Classic Visual Style is the standard
lined grippy. So, like I said, someone should file a bug under the Classic theme
to have XP draw the grippy. This will solve the problem in Classic, as under
Windows Classic the normal lines will be drawn, and under Luna the dotted grippy
will be drawn.

Comment 24

[Ben Ruppel]

Grey, what build are you using?  It used to draw the dots for me, and in recent
builds it started drawing lines.  That is what I am complaining about.  I think
it would be a good idea to respond further via email, before the other people on
this list get upset. (this is way off topic).

Comment 25

[Ben Ruppel]

Filed bug 188978.