Closed Bug 1841841 Opened 2 years ago Closed 11 months ago

Consider moving browser_notification_replace.js to dom/notification/test/browser

Categories

(Toolkit :: Alerts Service, task)

Product:
Toolkit
Component:
Alerts Service
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
127 Branch
Tracking Flags:
Tracking Status
firefox127 --- fixed

People

(Reporter: mconley, Assigned: saschanaz)

References

Details

Attachments

(1 file)

Bug 1841841 - Add notification tag WPT test and replace old ones r=asuth,hsingh
48 bytes, text/x-phabricator-request
Details | Review

The other tests in browser/base/content/test/alerts mainly concern the XUL backend / alerts service behaviours. browser_notification_replace.js seems to be more about how DOM notifications are represented, so it might make more sense under dom/notification/test/browser.

I think it can go since existing tests should cover that, but I'll check.

Assignee: nobody → krosylight
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c9e37a7248ac Add notification tag WPT test and replace old ones r=hsingh
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/45714 for changes under testing/web-platform/tests

Backed out for causing mass build bustages.

[task 2024-04-15T14:09:19.237Z] 14:09:19     INFO -  js/src> creating ./config.data
[task 2024-04-15T14:09:19.244Z] 14:09:19     INFO -  Creating config.status
[task 2024-04-15T14:09:19.500Z] 14:09:19     INFO -  Reticulating splines...
[task 2024-04-15T14:09:26.319Z] 14:09:26    ERROR -  Traceback (most recent call last):
[task 2024-04-15T14:09:26.320Z] 14:09:26     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/emitter.py", line 1785, in _process_test_manifest
[task 2024-04-15T14:09:26.320Z] 14:09:26     INFO -      raise SandboxValidationError(
[task 2024-04-15T14:09:26.320Z] 14:09:26     INFO -  mozbuild.frontend.reader.SandboxValidationError:
[task 2024-04-15T14:09:26.320Z] 14:09:26     INFO -  ==============================
[task 2024-04-15T14:09:26.320Z] 14:09:26     INFO -  FATAL ERROR PROCESSING MOZBUILD FILE
[task 2024-04-15T14:09:26.320Z] 14:09:26     INFO -  ==============================
[task 2024-04-15T14:09:26.320Z] 14:09:26     INFO -  The error occurred while processing the following file or one of the files it includes:
[task 2024-04-15T14:09:26.321Z] 14:09:26     INFO -      /builds/worker/checkouts/gecko/browser/base/moz.build
[task 2024-04-15T14:09:26.321Z] 14:09:26     INFO -  The error occurred when validating the result of the execution. The reported error is:
[task 2024-04-15T14:09:26.321Z] 14:09:26     INFO -      Test manifest (/builds/worker/checkouts/gecko/browser/base/content/test/alerts/browser.toml) lists test that does not exist: browser_notification_replace.js
[task 2024-04-15T14:09:26.321Z] 14:09:26     INFO -  During handling of the above exception, another exception occurred:
[task 2024-04-15T14:09:26.321Z] 14:09:26    ERROR -  Traceback (most recent call last):
[task 2024-04-15T14:09:26.322Z] 14:09:26     INFO -    File "/builds/worker/checkouts/gecko/configure.py", line 351, in <module>
[task 2024-04-15T14:09:26.322Z] 14:09:26     INFO -      sys.exit(main(sys.argv))
[task 2024-04-15T14:09:26.322Z] 14:09:26     INFO -    File "/builds/worker/checkouts/gecko/configure.py", line 176, in main
[task 2024-04-15T14:09:26.322Z] 14:09:26     INFO -      return config_status(config)
[task 2024-04-15T14:09:26.322Z] 14:09:26     INFO -    File "/builds/worker/checkouts/gecko/configure.py", line 300, in config_status
[task 2024-04-15T14:09:26.322Z] 14:09:26     INFO -      return config_status(args=[], **sanitized_config)
[task 2024-04-15T14:09:26.322Z] 14:09:26     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/config_status.py", line 200, in config_status
[task 2024-04-15T14:09:26.323Z] 14:09:26     INFO -      pool = BackendPool(definitions, processes=processes)
[task 2024-04-15T14:09:26.323Z] 14:09:26     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/config_status.py", line 53, in __init__
[task 2024-04-15T14:09:26.323Z] 14:09:26     INFO -      definitions = list(definitions)
[task 2024-04-15T14:09:26.323Z] 14:09:26     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/emitter.py", line 156, in emit
[task 2024-04-15T14:09:26.324Z] 14:09:26     INFO -      objs = list(emitfn(out))
[task 2024-04-15T14:09:26.324Z] 14:09:26     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/emitter.py", line 1577, in emit_from_context
[task 2024-04-15T14:09:26.324Z] 14:09:26     INFO -      for obj in self._process_test_manifests(context):
[task 2024-04-15T14:09:26.325Z] 14:09:26     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/emitter.py", line 1741, in _process_test_manifests
[task 2024-04-15T14:09:26.325Z] 14:09:26     INFO -      for obj in self._process_test_manifest(context, info, path, manifest):
[task 2024-04-15T14:09:26.325Z] 14:09:26     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/emitter.py", line 1866, in _process_test_manifest
[task 2024-04-15T14:09:26.325Z] 14:09:26     INFO -      raise SandboxValidationError(
[task 2024-04-15T14:09:26.325Z] 14:09:26     INFO -  mozbuild.frontend.reader.SandboxValidationError:
[task 2024-04-15T14:09:26.325Z] 14:09:26     INFO -  ==============================
[task 2024-04-15T14:09:26.325Z] 14:09:26     INFO -  FATAL ERROR PROCESSING MOZBUILD FILE
[task 2024-04-15T14:09:26.326Z] 14:09:26     INFO -  ==============================
[task 2024-04-15T14:09:26.326Z] 14:09:26     INFO -  The error occurred while processing the following file or one of the files it includes:
[task 2024-04-15T14:09:26.326Z] 14:09:26     INFO -      /builds/worker/checkouts/gecko/browser/base/moz.build
[task 2024-04-15T14:09:26.326Z] 14:09:26     INFO -  The error occurred when validating the result of the execution. The reported error is:
[task 2024-04-15T14:09:26.326Z] 14:09:26    ERROR -      Error processing test manifest file /builds/worker/checkouts/gecko/browser/base/content/test/alerts/browser.toml: Traceback (most recent call last):
[task 2024-04-15T14:09:26.327Z] 14:09:26     INFO -        File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/emitter.py", line 1785, in _process_test_manifest
[task 2024-04-15T14:09:26.327Z] 14:09:26     INFO -          raise SandboxValidationError(
[task 2024-04-15T14:09:26.327Z] 14:09:26     INFO -      mozbuild.frontend.reader.SandboxValidationError:
[task 2024-04-15T14:09:26.327Z] 14:09:26     INFO -      ==============================
[task 2024-04-15T14:09:26.327Z] 14:09:26     INFO -      FATAL ERROR PROCESSING MOZBUILD FILE
[task 2024-04-15T14:09:26.327Z] 14:09:26     INFO -      ==============================
[task 2024-04-15T14:09:26.327Z] 14:09:26     INFO -      The error occurred while processing the following file or one of the files it includes:
[task 2024-04-15T14:09:26.328Z] 14:09:26     INFO -          /builds/worker/checkouts/gecko/browser/base/moz.build
[task 2024-04-15T14:09:26.328Z] 14:09:26     INFO -      The error occurred when validating the result of the execution. The reported error is:
[task 2024-04-15T14:09:26.328Z] 14:09:26     INFO -          Test manifest (/builds/worker/checkouts/gecko/browser/base/content/test/alerts/browser.toml) lists test that does not exist: browser_notification_replace.js
[task 2024-04-15T14:09:27.198Z] 14:09:27     INFO -  *** Fix above errors and then restart with "./mach build"
[task 2024-04-15T14:09:27.312Z] 14:09:27     INFO - Return code: 1
[task 2024-04-15T14:09:27.312Z] 14:09:27  WARNING - setting return code to 2
[task 2024-04-15T14:09:27.313Z] 14:09:27    FATAL - 'mach build -v' did not run successfully. Please check log for errors.
[task 2024-04-15T14:09:27.313Z] 14:09:27    FATAL - Running post_fatal callback...
[task 2024-04-15T14:09:27.313Z] 14:09:27    FATAL - Exiting -1
[task 2024-04-15T14:09:27.313Z] 14:09:27     INFO - [mozharness: 2024-04-15 14:09:27.313096Z] Finished build step (failed)
Flags: needinfo?(krosylight)
Upstream PR was closed without merging

Oops.

Flags: needinfo?(krosylight)
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2dac985f6767 Add notification tag WPT test and replace old ones r=hsingh

https://hg.mozilla.org/mozilla-central/rev/2dac985f6767

Status: NEW → RESOLVED
Closed: 11 months ago
status-firefox127: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
Upstream PR merged by moz-wptsync-bot
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: