184199 - PAC fails to load (or reload) when switching proxy type

Status: RESOLVED WORKSFORME

(Core :: Networking, defect)

Description

[Nathan Kurz]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2b) Gecko/20021029 Phoenix/0.4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2b) Gecko/20021029 Phoenix/0.4

I've been trying to figure out some PAC things, and ran across another bug.
When changing from one proxy type to another, the PAC file does not reload
properly.  Normally this only causes subtle problems, but it may be masking
other errors. It's most apparent when switching from some other sort of proxy
going back to PAC.  This bug seems related to bug #80885, bug #82541, bug
#111445, and bug #85290.



Reproducible: Always

Steps to Reproduce:
1. Start with proxy set to type=0 (direct connection)
2. Using the UI, switch to proxy = 2 (PAC)
3. Do not change the PAC URL.  It must already be set properly.
4. Close preferences panel with OK.

Note: if you do change the URL, the reload occurs properly.  To see the error
properly, you should quit with the proxy set to direct, restart, then set the
proxy to the preconfigured PAC using only the radio button.
Actual Results:  
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "LocalFindProxyForURL is not a function"
{file:
"file:///usr/local/src/phoenix/mozilla/dist/bin/components/nsProxyAutoConfig.js"
line: 83}]' when calling method: [nsIProxyAutoConfig::ProxyForURL]"  nsresult:
"0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "<unknown>"
 data: yes]
************************************************************



This seems to be a simple typo in netwerk/base/src/nsProtocolProxyService.cpp
The conditional on line 236 should be checking (reloadPAC) not (!reloadPAC).
This change came in with another patch in version 1.18.

Comment 1

[Olivier Cahagne]

Marking NEW as there's a detailed analysis.

Comment 2

[Doug Turner (:dougt)]

-> darin

Comment 3

[Olivier Cahagne]

does it still happen with 1.4 ?
Eventhough line 248 hasn't changed:
[...]
 if (NS_SUCCEEDED(rv) && (!reloadPAC || strcmp(tempString.get(), mPACURL.get()))) 
249             ConfigureFromPAC(tempString);

Comment 4

[benc]

RESOLVED/WFM:
Mozilla 1.7f 2004-04-07, Mac OS X 

The reload occurs only in two situations: 

When the PAC URL has changed and PAC mode is activated (entering a PAC URL for
the first time, changing modes to PAC when the URL was changed)

When the reload button is pressed.

I'm not seeing the error you described, when you switch modes, PAC loads if it
needs to.