1841990 - Update irregexp to new version 30a887aeb92153885619d8bb9fa57cda7adf9276 from 2023-07-06 00:00:00

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Update Bot]

This update covers 1252 commits, including 167 new upstream commits I've never filed a bug on before. (They're the top 167.). Here are the overall diff statistics.

---

js/src/irregexp/imported/regexp-ast.h | 6 +-
js/src/irregexp/imported/regexp-bytecode-generator.cc | 2 +-
js/src/irregexp/imported/regexp-bytecode-generator.h | 4 +-
js/src/irregexp/imported/regexp-bytecode-peephole.cc | 56 +++++++++---------
js/src/irregexp/imported/regexp-bytecode-peephole.h | 5 +-
js/src/irregexp/imported/regexp-bytecodes.cc | 7 +-
js/src/irregexp/imported/regexp-bytecodes.h | 5 +-
js/src/irregexp/imported/regexp-compiler-tonode.cc | 1 +
js/src/irregexp/imported/regexp-interpreter.cc | 28 +++++----
js/src/irregexp/imported/regexp-macro-assembler.cc | 20 +++---
js/src/irregexp/imported/regexp-macro-assembler.h | 14 ++--
js/src/irregexp/imported/regexp-parser.cc | 21 ++----
js/src/irregexp/imported/regexp-stack.cc | 2 +-
js/src/irregexp/imported/regexp-stack.h | 8 +-
js/src/irregexp/moz.yaml | 4 +-
15 files changed, 92 insertions(+), 91 deletions(-)

Comment 2

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=1980b55698b38b78623fca0d90534b8b10efbb16

Comment 3

[Update Bot]

Attachment: Bug 1841990 - Update irregexp to 30a887aeb92153885619d8bb9fa57cda7adf9276

Comment 4

[Update Bot]

All jobs completed, we found the following issues.

Known Issues (From Taskcluster):

• spidermonkey-sm-plain-linux32/debug (eQLZvWrJQaS5N6dp8IjKIA) - new failure not classified
• spidermonkey-sm-temporal-linux64/debug (KlgNxofdRUqBCDfC83o6cg) - new failure not classified
• spidermonkey-sm-plain-linux64/opt (AWrpDCVeQfmlVaA-W_vkSg) - new failure not classified
• spidermonkey-sm-linux64-wasi-intl/opt (cVwC-0DRRteUMR4AMA9skw) - new failure not classified
• spidermonkey-sm-asan-linux64/opt (BynXH5kRQ2K5THNB0hKR8w) - new failure not classified
• spidermonkey-sm-rootanalysis-linux64/debug (E2VRNlSRQHeN_Bpy4AI4Mw) - new failure not classified
• spidermonkey-sm-fuzzilli-linux64/debug (Kf_vJH2yRgegmhcutGsh4g) - new failure not classified
• spidermonkey-sm-compacting-linux64/debug (EhCnd484RCigL0YkezePwQ) - new failure not classified
• spidermonkey-sm-nonunified-linux64/debug (RjYjngqRTted6nx6xbB6uw) - new failure not classified
• spidermonkey-sm-arm-sim-linux32/debug (fkXqTOnETY6oD95ia-K8_A) - new failure not classified
• hazard-linux64-shell-haz/debug (C38klqo0T4mHA0Mvo80s8w) - new failure not classified
• spidermonkey-sm-linux64-wasi/opt (eH1Z9-cISMq-DwK_YgH_Jw) - new failure not classified
• spidermonkey-sm-plain-linux64/debug (D7YukDaxTwyJ7nMY0gKvaQ) - new failure not classified
• spidermonkey-sm-rt-linux64/debug (KXtE9aSGTj2kFbHO0DFr_A) - new failure not classified
• spidermonkey-sm-wasm-no-experimental-linux64/debug (KRbrihV4RIWcORzPkwiMDA) - new failure not classified
• spidermonkey-sm-package-linux64/opt (KZFMAdgdQVyhRoWtyGn9dQ) - new failure not classified
• spidermonkey-sm-nojit-linux64/opt (Ve1Rw7PFTAST_4AuHHoxIQ) - new failure not classified
• spidermonkey-sm-arm64-sim-linux64/debug (H9JUTnvzRIup3h41tqRzhg) - new failure not classified
• spidermonkey-sm-gdb-linux64/debug (Tos34k08TDmcQb-f8BceAw) - new failure not classified
• spidermonkey-sm-fuzzing-linux64/opt (GQiqfVDRQB2AgaM-DZ6kTg) - new failure not classified
• spidermonkey-sm-tsan-linux64/opt (OA5c3DNPQ_aoscIq14bz6g) - new failure not classified

These failures may mean that the library update succeeded; you'll need to review
them yourself and decide. If there are lint failures, you will need to fix them in
a follow-up patch. (Or ignore the patch I made, and recreate it yourself with
./mach vendor js/src/irregexp/moz.yaml.)

In either event, I have done all I can, so you will need to take it from here.
When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 5

[Iain Ireland [:iain]]

Attachment: Bug 1841990: Add SmallZoneVector r=sfink

Comment 6

[Iain Ireland [:iain]]

Attachment: Bug 1841990: Remove byte typedef from regexp shim r=sfink

V8 replaced byte with uint8_t throughout irregexp, so we no longer need it in the shim.

Depends on D182941

Comment 7

[Iain Ireland [:iain]]

Attachment: Bug 1841990: Add test r=sfink

Depends on D182942

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c46de639447b
Update irregexp to 30a887aeb92153885619d8bb9fa57cda7adf9276 r=iain
https://hg.mozilla.org/integration/autoland/rev/3485b5cbbfb5
Add SmallZoneVector r=sfink
https://hg.mozilla.org/integration/autoland/rev/55a1b5621472
Remove byte typedef from regexp shim r=sfink
https://hg.mozilla.org/integration/autoland/rev/1ff96a1c6bdb
Add test r=sfink

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c46de639447b
https://hg.mozilla.org/mozilla-central/rev/3485b5cbbfb5
https://hg.mozilla.org/mozilla-central/rev/55a1b5621472
https://hg.mozilla.org/mozilla-central/rev/1ff96a1c6bdb