184207 - name/value pairs not being submitted on submit()

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[John Keiser (jkeiser)]

When you have <input type=submit name=x value=y onclick='this.form.submit()'>
the x=y should submit (the web developer who wrote the html code in question
should be shot as well).  This is a regression of bug 138957.

Comment 1

[John Keiser (jkeiser)]

Attachment: Patch

The problem is that mPendingSubmission is getting set to false in
nsHTMLFormElement::HandleDOMEvent() during the capture stage of the onclick
handler.  This patch fixes the problem by not setting mPendingSubmission =
FALSE unless it is the submit event.  It also shuffles the part that resets
mPendingSubmission = null to the submit() method and adds an assertion, so that
we can catch cases where submissions fall through the cracks a little easier.

Comment 2

[John Keiser (jkeiser)]

Attachment: Testcase

Comment 3

[John Keiser (jkeiser)]

Attachment: Patch v1.1

Merge to trunk, and don't flush on reset.

Comment 4

[Alexandru Savulov]

Comment on attachment 109247 [details] [diff] [review]
Patch v1.1

ok this cancels the patch i prepared for the regression bug 184931. good to go
dude!

Comment 5

[Alexandru Savulov]

this one is really important be cause of the regression bug 184931

Comment 6

[Felix Miata]

Bug 184931 is an ALL/ALL bug, should not be wontfixed, since this bug is not
ALL/ALL and is either a dupe of or will create a worksforme in the other.

Comment 7

[kinmoz]

Comment on attachment 109247 [details] [diff] [review]
Patch v1.1

sr=[e-mail]

Comment 8

[John Keiser (jkeiser)]

Fix checked in.

Comment 9

[Vladimir Ermakov]

verifying.