Closed Bug 1842108 Opened 2 years ago Closed 2 years ago

Add pypa/gh-action-pypi-publish@release/v1 to mozilla org

Categories

(mozilla.org :: Github: Administration, task)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: robhudson, Unassigned)

Details

I'm testing out publishing a Python package via tagging a relase on Github. The current security recommendation for this Github action (pypa/gh-action-pypi-publish) is to use Trusted Publishing (https://docs.pypi.org/trusted-publishers/) which is available in versions >= 1.8.0 of this Github action.

The docs recommend using the latest v1 release, specified by pypa/gh-action-pypi-publish@release/v1 or use an exact version.

However, the only version allowed in the mozilla org currently is pypa/gh-action-pypi-publish@v1.4.2, as noted in the error I received for my run here: https://github.com/mozilla/basket-client/actions/runs/5480970519

I would like to either get this opened up to any v1 release or have it updated to a current version that supports trusted publishing.

Thanks,
Rob

NI set for secops to weigh in on this - the original was approved over in bug 1710299 - Austin - please let me know if you have questions or concerns.

Not sure what the syntax would be to allow @v1 and @v1.4.2 ... @v1*? Mainly, I'm loathe to break existing workflows.

Flags: needinfo?(asargent)

Approved by SecOps

I wish there was an easier way to say something like anything v1 or greater (@v1>)?

Regardless, lets do: pypa/gh-action-pypi-publish@release/v1* and should we need to bump to v2, we can do a new separate ticket for tracking.

Flags: needinfo?(asargent)

Alright, I've made that change. Given that the original repo is specifying the exact version using a different syntax I did NOT remove that entry from the list.

Please confirm things are working as expected.

Flags: needinfo?(robhudson)

Works great, thank you!

Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(robhudson)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.