Open Bug 1842200 Opened 2 years ago Updated 28 days ago

Intermittent leakcheck | tab 5800 bytes leaked (ChannelEventQueue, CondVar, CookieJarSettings, DOMEventTargetHelper, ListenerAndContextContainer, ...)

Categories

(Core :: Networking: WebSockets, defect, P3)

Product:
Core
Component:
Networking: WebSockets
Type:
defect

Tracking

()

People

(Reporter: intermittent-bug-filer, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, leave-open, Whiteboard: [necko-triaged][stockwell disabled])

Attachments

(1 file)

Bug 1842200 - Disable browser_net_telemetry_select_ws_frame.js for frequent intermittent leaks on Linux debug.
48 bytes, text/x-phabricator-request
Details | Review

Filed by: nerli [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=421880512&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/bLW31UCmRCy39VHLwFsb0g/runs/0/artifacts/public/logs/live_backing.log

[task 2023-07-07T12:29:14.420Z] 12:29:14     INFO - TEST-INFO | leakcheck | tab leaked 23 nsStringBuffer
[task 2023-07-07T12:29:14.421Z] 12:29:14     INFO - TEST-INFO | leakcheck | tab leaked 1 nsThread
[task 2023-07-07T12:29:14.421Z] 12:29:14     INFO - TEST-INFO | leakcheck | tab leaked 4 nsWeakReference
[task 2023-07-07T12:29:14.422Z] 12:29:14     INFO - TEST-UNEXPECTED-FAIL | leakcheck | tab 5800 bytes leaked (ChannelEventQueue, CondVar, CookieJarSettings, DOMEventTargetHelper, ListenerAndContextContainer, ...)
[task 2023-07-07T12:29:14.422Z] 12:29:14     INFO - 
[task 2023-07-07T12:29:14.423Z] 12:29:14     INFO - leakcheck | Processing leak log file /tmp/tmp4e5afzny.mozrunner/runtests_leaks_tab_pid3235.log
[task 2023-07-07T12:29:14.424Z] 12:29:14     INFO - TEST-PASS | leakcheck | tab no leaks detected!
[task 2023-07-07T12:29:14.425Z] 12:29:14     INFO - leakcheck | Processing leak log file /tmp/tmp4e5afzny.mozrunner/runtests_leaks_tab_pid3536.log
[task 2023-07-07T12:29:14.426Z] 12:29:14     INFO - TEST-PASS | leakcheck | tab no leaks detected!

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit BugBot documentation.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INCOMPLETE

New failure instance: https://treeherder.mozilla.org/logviewer?job_id=427082950&repo=autoland

Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

Looking at recent logs, this seems to involve web sockets.

Component: Widget: Gtk → Networking: WebSockets
Blocks: websocket-tests
Priority: P5 → P3
Whiteboard: [necko-triaged]
Status: REOPENED → NEW
Whiteboard: [necko-triaged][stockwell needswork:owner] → [necko-triaged][stockwell needswork:owner][necko-priority-next]

The last test that's running seems to be:
devtools/client/netmonitor/test/browser_net_zstd.js

A few of the previous ones:
devtools/client/netmonitor/test/browser_net_ws-messages-navigation.js
devtools/client/netmonitor/test/browser_net_ws-sockjs-stomp-payload.js
devtools/client/netmonitor/test/browser_net_ws-limit-payload.js
...

These are more likely to be causing the leak.

I looked at about a half dozen of these logs. In every case, the leaking content process was created shortly after the start of the test browser_net_telemetry_select_ws_frame.js. In two cases I spot checked, the leaking process was shut down shortly before the end of that test.

I made some attempts to reproduce this leak on Try with logging enabled, but I was unable to. A previous networking-related leak I looked at was some kind of shutdown race involving code after the shutdown CC, so it was very sensitive to changes in timing caused by logging. Maybe something similar is at work here.

Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/91cbec6b9fc7 Disable browser_net_telemetry_select_ws_frame.js for frequent intermittent leaks on Linux debug. r=intermittent-reviewers,jmaher
Whiteboard: [necko-triaged][necko-priority-next][stockwell disable-recommended] → [necko-triaged][necko-priority-next][stockwell disabled]

Unfortunately, my disabling patch does not seem to have fixed the leak. In two logs I checked, the leaking process was created during browser_net_ws-filter-dropdown.js.

In one log I looked at, the process goes from XPCOM startup to XPCOM shutdown in about 5 seconds, so maybe there's some race from closing down a process too quickly.

Whiteboard: [necko-triaged][necko-priority-next][stockwell disabled] → [necko-triaged][stockwell disabled]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: