1842277 - Make xywh() compute to the equivalent inset() function

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Boris Chiou [:boris]]

Per https://drafts.csswg.org/css-shapes-1/#basic-shape-computed-values, we should make inset()/xywh()/rect() compute to the equivalent inset() function

Comment 1

[Boris Chiou [:boris]]

Attachment: Bug 1842277 - Compute <basic-shape-rect> to the equivalent inset() function.

Per spec
https://drafts.csswg.org/css-shapes-1/#basic-shape-computed-values, and
the spec issue, https://github.com/w3c/csswg-drafts/issues/9053,
all <basic-shape-rect> functions compute to the equivalent inset() function.
i.e.
xywh(x y w h) computes to
inset(y calc(100% - x - w) calc(100% - y - h) x)

Also, tweak the test, offset-path-shape-xywh-003, because the original
xywh(10% 10% 80% 80%) has to calculate calc(100% - calc(10% + 80%)),
whose result is Percentage(0.099999964) in Rust code, and then it makes us
compute an imprecision inset rect when building the gfx::path, so the result
becomes fuzzy because of the sub-pixel translation.

So change it to xywh(10% 10% 90% 90%) to avoid adding fuzzy tolerance.

Comment 2

[Boris Chiou [:boris]]

Attachment: Bug 1842277 - Add tests for basic-shape-rect and drop duplicate tests from test_transitions_per_property.html.

Now xywh() and inset() should be interpolable, so add some tests for it.

Also, we have a lot of interpolation tests for motion in WPT, so it's
unnecessary to have the similar tests in test_transitions_per_property.html.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19f42d47ba8d
Compute <basic-shape-rect> to the equivalent inset() function. r=devtools-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/86b90f83c914
Add tests for basic-shape-rect and drop duplicate tests from test_transitions_per_property.html. r=emilio

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41004 for changes under testing/web-platform/tests

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/19f42d47ba8d
https://hg.mozilla.org/mozilla-central/rev/86b90f83c914

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot