1842380 - Incorrect wording in Add-ons and themes > Recommendations

Status: RESOLVED DUPLICATE of bug 1840953

(Toolkit :: Add-ons Manager, defect)

Description

[Timur Timirkhanov]

Steps to reproduce

1. Download latest nightly
2. Main menu > Add-ons and themes > Recommendations tab

Actual results:
Here’s a selection Firefox Learn more for exceptional security, performance, and functionality.

Expected results:
Here’s a selection Nightly recommends for exceptional security, performance, and functionality.

Seems that it incorrectly processes the string template in https://pontoon.mozilla.org/ru/firefox/all-resources/?string=198608

Originally reported by [e-mail]

Comment 1

[❌ PTO, back 8/31 ❌ Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: screenshot of bug

Thanks for filing this bug! This string indeed looks quite funny (see screenshot).

:flod, any idea how we might want to triage this from here?

Comment 2

[Francesco Lodolo [:flod]]

Not exactly a localization problem, it's unfortunate that it took us so long to notice :-(

This was regressed in https://hg.mozilla.org/mozilla-central/rev/41490c3a916a0e7186b0d80dafaddc1708678d35

moz-support-link is designed to replace stand-alone links, not links in the middle of the sentence. I strongly suggest to leave the existing string as is, and revert the code change above (which should also be uplifted to ESR 115).

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1804695

:tgiles, since you are the author of the regressor, bug 1804695, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Tim Giles [:tgiles]]

Seems like we need to uplift Bug 1840953 to ESR 115 then. I'll make sure to get that done.