184244 - CIRCChanMode.prototype.setSecret uses +p instead of +s

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Justin Turner Arthur]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3a) Gecko/20021115
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3a) Gecko/20021115

In irc.js, it looks like the CIRCChanMode.prototype.setSecret method is
identical to CIRCChanMode.prototype.setPvt method.
The part that I think needs changing is this:
    this.parent.parent.sendData ("MODE " + this.parent.encodedName + " " +
                                 modifier + "p\n");
Where "p\n" should be replaced with "s\n" in the setSecret method. Everywhere
else in script differentiates between the two modes, so I assume that this part
was intended to do the same.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[James Ross]

You're right, it does seem wrong. Patch coming up in a minute.

Comment 2

[James Ross]

Attachment: diff -U 6 of irc.js

Comment 3

[Robert Ginda]

I've got this in my local tree

Comment 4

[Robert Ginda]

checked in