1842610 - Make updates to recentlyclosed.mjs in about:firefoxview-next after latest SessionStore updates

Status: RESOLVED FIXED

(Firefox :: Firefox View, task)

Description

[Kelly Cochrane [:kcochrane]]

Recent updates have been made to SessionStore in bug 1819675 to include recently closed tabs from all windows. We should update recentlyclosed.mjs (added in bug 1828606) to utilize these new updates.

You can reference changes made to the existing recently-closed.mjs file here:
https://hg.mozilla.org/mozilla-central/diff/e5be8edfd9cf421f756c321aa1c67273692d43bf/browser/components/firefoxview/recently-closed-tabs.mjs

Comment 1

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1842610 - Add SessionStore.forgetClosedWindowById and forgetClosedTabById and update RecentlyClosedTabsInView to use the new forget and aggregated getClosedTabData methods. r?kcochrane!

• We already make use of the closedId in RecentlyClosedTabsInView to re-open the tab via SS.undoCloseById so it made sense to do the same for forgetting a closed tab
• In the test setup, one of tabs is opened and closed in a different window. This gives us coverage both for the closed tab list rendering, as well as re-opening and forgeting tabs with different source windows

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55f52c3ae61c
Add SessionStore.forgetClosedWindowById and forgetClosedTabById and update RecentlyClosedTabsInView to use the new forget and aggregated getClosedTabData methods. r=kcochrane,fxview-reviewers,sessionstore-reviewers,dao,sclements

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/55f52c3ae61c