Closed Bug 1842610 Opened 9 months ago Closed 9 months ago

Make updates to recentlyclosed.mjs in about:firefoxview-next after latest SessionStore updates

Categories

(Firefox :: Firefox View, task)

task

Tracking

()

RESOLVED FIXED
118 Branch
Tracking Status
firefox118 --- fixed

People

(Reporter: kcochrane, Assigned: sfoster)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-firefox-view])

Attachments

(1 file)

Recent updates have been made to SessionStore in bug 1819675 to include recently closed tabs from all windows. We should update recentlyclosed.mjs (added in bug 1828606) to utilize these new updates.

You can reference changes made to the existing recently-closed.mjs file here:
https://hg.mozilla.org/mozilla-central/diff/e5be8edfd9cf421f756c321aa1c67273692d43bf/browser/components/firefoxview/recently-closed-tabs.mjs

Assignee: nobody → sfoster
  • We already make use of the closedId in RecentlyClosedTabsInView to re-open the tab via SS.undoCloseById so it made sense to do the same for forgetting a closed tab
  • In the test setup, one of tabs is opened and closed in a different window. This gives us coverage both for the closed tab list rendering, as well as re-opening and forgeting tabs with different source windows
Attachment #9344982 - Attachment description: Bug 1842610 - Add a SessionStore.forgetByCloseId, use SS.getClosedTabData in RecentlyClosedTabsInView and the new SS.forgetByCloseId when handling the dismiss action. r?kcochrane! → Bug 1842610 - Add SessionStore.forgetClosedWindowById and forgetClosedTabById and update RecentlyClosedTabsInView to use the new forget and aggregated getClosedTabData methods. r?kcochrane!
Blocks: 1833522
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/55f52c3ae61c
Add SessionStore.forgetClosedWindowById and forgetClosedTabById and update RecentlyClosedTabsInView to use the new forget and aggregated getClosedTabData methods. r=kcochrane,fxview-reviewers,sessionstore-reviewers,dao,sclements
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
Blocks: 1850630
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: