1842647 - ./mach vendor failing to honor an `exclude` entry

Status: RESOLVED FIXED

(Developer Infrastructure :: Mach Vendor & Updatebot, defect)

Description

[Jonathan Kew [:jfkthame]]

In gfx/harfbuzz/moz.yaml, we have an entry under exclude:

    - "src/test*"

which is intended to cause various test files present in the upstream src/ directory to be omitted when vendoring into Gecko.

However, this doesn't appear to work; running ./mach vendor gfx/harfbuzz/moz.yaml, the test files (test.cc, and a bunch of individual test-*.cc files) get included in the tree, and added to the moz.build file (which then results in a build failure).

Is this exclude pattern not valid (i.e. this is simply user error), in which case what would be the proper form? Or is ./mach vendor misbehaving?

Comment 1

[Tom Ritter [:tjr]]

The problem comes from this line

The problem is basically precedence. If src is in include and src/test* is in exclude, then logically you want the src/test* files excluded. But if ** is in exclude and src is in include, logically you want the src directory included. But these are the same scenario.

Comment 2

[Tom Ritter [:tjr]]

Attachment: Bug 1842647: More intelligently handle a file that matches both patterns. r?jewilde

Comment 3

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:tjr, could you have a look please?

For more information, please visit BugBot documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26c26e73c08c
More intelligently handle a file that matches both patterns. r=jewilde

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/26c26e73c08c