1842916 - Failed to install add-on error when cancelling or dismissing the extension permissions dialog

Status: RESOLVED FIXED

(Firefox for Android :: WebExtensions, defect, P1)

Description

[Arturo Mejia [:amejia]]

Steps to reproduce

1. Open Add-ons manager
2. Tap + to install
3. Tap cancel on the permission dialog

Expected behavior

Dismiss the dialog and not display an error.

Actual behavior

Dismiss the dialog and an error is displayed.

Device information

• Firefox version:
  Fx 117 and 116

Any additional information?

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1842916 - Expose InstallationWebExtensionException.UserCancelled. (#2817)

Comment 2

[BMO Github Automation]

Authored by https://github.com/Amejia481
https://github.com/mozilla-mobile/firefox-android/commit/6a2a18641da58a04ed8202dd7a0f05d6b582a7de
[main] Bug 1842916 - Expose WebExtensionInstallException.UserCancelled.

Comment 3

[Lorand Janos]

Managed to reproduce the issue on an earlier Nightly build (2023-07-04).
Verified as fixed on the latest Nightly build (2023-07-13).
Device used: Google Pixel 7 (Android 14).
Marking the ticket as verified.

Comment 4

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1842916 - Expose WebExtensionInstallException.UserCancelled. (backport #2817) (#2837)

Comment 5

[Arturo Mejia [:amejia]]

Comment on attachment 9343549 [details] [review]
[mozilla-mobile/firefox-android] Bug 1842916 - Expose InstallationWebExtensionException.UserCancelled. (#2817)

Beta/Release Uplift Approval Request

• User impact if declined: User will get an error when rejecting the permissions dialog when installing an add-on
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We are just preventing the error message to show when the user cancelled the permissions dialog when installing an add-on
• String changes made/needed:
• Is Android affected?: Yes

Comment 6

[Dianna Smith [:diannaS]]

Comment on attachment 9343780 [details] [review]
[mozilla-mobile/firefox-android] Bug 1842916 - Expose WebExtensionInstallException.UserCancelled. (backport #2817) (#2837)

Approved for Mobile 116.0b5

Comment 7

[BMO Github Automation]

Authored by https://github.com/mergify[bot]
https://github.com/mozilla-mobile/firefox-android/commit/18a1225d5b1edb87735654d92f2004931565a981
[releases_v116] Bug 1842916 - Expose WebExtensionInstallException.UserCancelled. (#2837)

Comment 8

[Adina Petridean QA [:apetridean]]

Verified as fixed on the Firefox Beta 116.0b5
Devices used: Google Pixel 7 PRO (Android 14)
Motorola Moto G9 plus (Android 11)