1842933 - arm_neon.h:10357:1: error: inlining failed in call to ‘always_inline’ ‘vld1_u8’: target specific option mismatch

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Mike Hommey [:glandium]]

When building with --with-system-libvpx, building for linux armhf fails with:

In file included from /<<PKGBUILDDIR>>/third_party/aom/aom_dsp/arm/blend_a64_mask_neon.c:12:
/usr/lib/gcc/arm-linux-gnueabihf/12/include/arm_neon.h: In function ‘load_u8_8x8’:
/usr/lib/gcc/arm-linux-gnueabihf/12/include/arm_neon.h:10357:1: error: inlining failed in call to ‘always_inline’ ‘vld1_u8’: target specific option mismatch
10357 | vld1_u8 (const uint8_t * __a)
      | ^~~~~~~
In file included from /<<PKGBUILDDIR>>/third_party/aom/aom_dsp/arm/blend_a64_mask_neon.c:19:
/<<PKGBUILDDIR>>/third_party/aom/av1/common/arm/mem_neon.h:52:9: note: called from here
   52 |   *s7 = vld1_u8(s);
      |         ^~~~~~~~~~
/usr/lib/gcc/arm-linux-gnueabihf/12/include/arm_neon.h:10357:1: error: inlining failed in call to ‘always_inline’ ‘vld1_u8’: target specific option mismatch
10357 | vld1_u8 (const uint8_t * __a)
      | ^~~~~~~
/<<PKGBUILDDIR>>/third_party/aom/av1/common/arm/mem_neon.h:50:9: note: called from here
   50 |   *s6 = vld1_u8(s);
      |         ^~~~~~~~~~

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1842933 - Use NEON_FLAGS instead of VPX_ASFLAGS for libaom neon code.

Back when libaom was added, VPX_ASFLAGS was more or less the only
variable that had the right set of flags for NEON support, which
justified its use. However, it's not set when building against system
libvpx.

Bug 1791482 improved things, though, and VPX_ASFLAGS, as far as NEON is
concerned, is now only re-exporting NEON_FLAGS, with the same caveat that
VPX_ASFLAGS is empty when building against system libvpx.

So we should use NEON_FLAGS instead of VPX_ASFLAGS.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2cb4675f1ae9
Use NEON_FLAGS instead of VPX_ASFLAGS for libaom neon code. r=firefox-build-system-reviewers,andi

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 9343377 [details]
Bug 1842933 - Use NEON_FLAGS instead of VPX_ASFLAGS for libaom neon code.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Build failure in some configurations (armhf linux with --with-system-libvpx)
• User impact if declined: See above.
• Fix Landed on Version: 117
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): NPOTB

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2cb4675f1ae9

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9343377 [details]
Bug 1842933 - Use NEON_FLAGS instead of VPX_ASFLAGS for libaom neon code.

Approved for 115.1esr.

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/8cfd1d58d899