Closed
Bug 1842934
Opened 3 years ago
Closed 3 years ago
detect_upstream_revert.sh falsely identifies upstream revert if multiple commits have same summary line
Categories
(Core :: WebRTC, task, P2)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
117 Branch
| Tracking | Status | |
|---|---|---|
| firefox117 | --- | fixed |
People
(Reporter: mjf, Assigned: mjf)
Details
Attachments
(1 file)
detect_upstream_revert.sh naively compares the summary lines of future commits to detect a case where we'll see a commit and then a revert commit. Most revert commits contain a line in the commit message like "This reverts commit {sha}" so we'll grab that and check the more naively acquired sha to make sure they match.
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → mfroman
Severity: -- → S3
Priority: -- → P2
|
|
Assignee | |
Comment 1•3 years ago
|
||
Pushed by mfroman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f33e293d8af1
improve upstream revert detection to also use embedded revert commit label. r=dbaker DONTBUILD
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox117:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•