Closed Bug 1842947 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 40979 - Handle no streams case in RendererImpl.

Categories

(Core :: Audio/Video: Playback, task, P4)

Product:
Core
Component:
Audio/Video: Playback
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
117 Branch
Tracking Flags:
Tracking Status
firefox117 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 40979 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40979
Details from upstream follow.

Dale Curtis <dalecurtis@chromium.org> wrote:

Handle no streams case in RendererImpl.

It seems that when the MediaSource is torn down in a worker, we
may end up in a transient state without any streams. Fail instead
of DCHECK crashing.

Also improve the test logging to see what the issue is.

R=xhwang

Bug: 1462962
Change-Id: I9cc3b59b832e5fdb0a2da4a4ff309cb2b335aea6
Reviewed-on: https://chromium-review.googlesource.com/4679283
WPT-Export-Revision: 7d296f75371336f0266154684cd357f36d3956d3

Component: web-platform-tests → Audio/Video: Playback
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 30 subtests

Status Summary

Firefox

OK : 1
FAIL: 30

Chrome

OK : 1
PASS: 30

Safari

OK : 1
FAIL: 30

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /media-source/dedicated-worker/mediasource-worker-play-terminate-worker.html [wpt.fyi]
    • Test worker MediaSource termination after at least 0 main thread setTimeouts, starting counting before setting srcObject: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 1 main thread setTimeouts, starting counting before setting srcObject: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 2 main thread setTimeouts, starting counting before setting srcObject: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 3 main thread setTimeouts, starting counting before setting srcObject: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 4 main thread setTimeouts, starting counting before setting srcObject: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 5 main thread setTimeouts, starting counting before setting srcObject: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 6 main thread setTimeouts, starting counting before setting srcObject: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 7 main thread setTimeouts, starting counting before setting srcObject: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 8 main thread setTimeouts, starting counting before setting srcObject: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 9 main thread setTimeouts, starting counting before setting srcObject: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 0 main thread setTimeouts, starting counting after setting srcObject: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 1 main thread setTimeouts, starting counting after setting srcObject: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 2 main thread setTimeouts, starting counting after setting srcObject: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 3 main thread setTimeouts, starting counting after setting srcObject: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 4 main thread setTimeouts, starting counting after setting srcObject: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 5 main thread setTimeouts, starting counting after setting srcObject: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 6 main thread setTimeouts, starting counting after setting srcObject: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 7 main thread setTimeouts, starting counting after setting srcObject: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 8 main thread setTimeouts, starting counting after setting srcObject: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 9 main thread setTimeouts, starting counting after setting srcObject: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 0 main thread setTimeouts, starting counting after first ended event: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 1 main thread setTimeouts, starting counting after first ended event: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 2 main thread setTimeouts, starting counting after first ended event: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 3 main thread setTimeouts, starting counting after first ended event: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 4 main thread setTimeouts, starting counting after first ended event: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 5 main thread setTimeouts, starting counting after first ended event: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 6 main thread setTimeouts, starting counting after first ended event: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 7 main thread setTimeouts, starting counting after first ended event: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 8 main thread setTimeouts, starting counting after first ended event: FAIL (Chrome: PASS, Safari: FAIL)
    • Test worker MediaSource termination after at least 9 main thread setTimeouts, starting counting after first ended event: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a480b46b9529 [wpt PR 40979] - Handle no streams case in RendererImpl., a=testonly

https://hg.mozilla.org/mozilla-central/rev/a480b46b9529

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox117: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
You need to log in before you can comment on or make changes to this bug.