Open Bug 1843035 Opened 1 year ago Updated 9 months ago

Align unbinding a popover node from the tree closer to the spec

Categories

(Core :: DOM: Core & HTML, enhancement)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement

Tracking

()

People

(Reporter: mbrodesser-Igalia, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(3 obsolete files)

No description provided.
Attachment #9343480 - Attachment description: Bug 1843035: align unbinding a popover node from the tree closer to the spec. r=emilio → Bug 1843035: part 1) Align unbinding a popover node from the tree closer to the spec. r=emilio
Pushed by mbrodesser@igalia.com:
https://hg.mozilla.org/integration/autoland/rev/238e99b4449c
part 1) Align unbinding a popover node from the tree closer to the spec. r=emilio
https://hg.mozilla.org/integration/autoland/rev/d44bf85938f0
part 2) Assert correctness of popover attribute state at all relevant callers of `GetPopoverAttributeState()`. r=emilio

Backed out for causing assertion failures in dom/html/nsGenericHTMLElement.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/3f0b7eb09dcdc53eee9f9482f2966f6ef1c29d91

Push with failures

Failure log -> Assertion failure: !HasAttr(nsGkAtoms::popover), at /builds/worker/checkouts/gecko/dom/html/nsGenericHTMLElement.cpp

Flags: needinfo?(mbrodesser)

Otherwise, some tentative tests fail. It's cleaner anyway.

Depends on D183477

Flags: needinfo?(mbrodesser)
Assignee: mbrodesser → nobody
Status: ASSIGNED → NEW
Attachment #9343661 - Attachment is obsolete: true
Attachment #9343480 - Attachment is obsolete: true
Attachment #9344578 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: