1843035 - Align unbinding a popover node from the tree closer to the spec

Status: NEW

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1843035: part 1) Align unbinding a popover node from the tree closer to the spec. r=emilio

Comment 2

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1843035: part 2) Assert correctness of popover attribute state at all relevant callers of `GetPopoverAttributeState()`. r=emilio

Depends on D183381

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/238e99b4449c
part 1) Align unbinding a popover node from the tree closer to the spec. r=emilio
https://hg.mozilla.org/integration/autoland/rev/d44bf85938f0
part 2) Assert correctness of popover attribute state at all relevant callers of `GetPopoverAttributeState()`. r=emilio

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing assertion failures in dom/html/nsGenericHTMLElement.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/3f0b7eb09dcdc53eee9f9482f2966f6ef1c29d91

Push with failures

Failure log -> Assertion failure: !HasAttr(nsGkAtoms::popover), at /builds/worker/checkouts/gecko/dom/html/nsGenericHTMLElement.cpp

Comment 5

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1843035: part 3) Guard executing popover related code when unbinding a node from the tree behind the popover pref. r=emilio

Otherwise, some tentative tests fail. It's cleaner anyway.

Depends on D183477