1843119 - Remove SpinEventLoopUntil from WifiMonitor

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[David Parks [:handyman]]

The old WifiMonitor setup needed to use SpinEventLoopUntil for synchronization with the wifi monitor thread but the new setup doesn't need it. The SpinEventLoopUntil calls currently make sure that the main thread has sent the wifi scan update before it starts the timer for the next scan (when polling wifi scans). This is overkill. The main thread task should run almost immediately. Also, a stalled main thread doesn't imply no-geolocation-change, so we should be running the next scan on time anyway. And there's the fact that SpinEventLoopUntil should be used as a last resort.

Comment 1

[David Parks [:handyman]]

Attachment: Bug 1843119: Remove SpinEventLoopUntil from nsWifiMonitor r=#necko-reviewers!

We were using SpinEventLoopUntil to order the scans and the scan results but this seems to be overkill -- we should expect the main loop to process our tasks ery quickly. In addition, it's probably not desirable to wait before scheduling the next scan because a delay in main thread processing doesn't imply lack of movement so our update is still needed. Finally, we try to avoid SpinEventLoopUntil as much as possible.

Comment 2

[David Parks [:handyman]]

https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=WUyCuZJnRHCCMpMNnb-3Eg.0&revision=e94a10b6f4d9245cdce332fdb4158c40c694ad4c

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbf3c24cbbc7
Remove SpinEventLoopUntil from nsWifiMonitor r=necko-reviewers,kershaw

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/bbf3c24cbbc7