1843130 - Pocket newtab use new recs api for locale list config if new api pref is set

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[Scott [:thecount] Downe]

The new api previously had an issue with locale-list-config, locale-list-config is a csv of locales that get Pocket stories regardless of region. It is empty on release and beta, but on nightly we have it set to en-US, en-CA, and en-GB. So in nightly all english users see english Pocket stories regardless of location.

The issue with the new api is that English browsers located in the new markets would then use the new api. However the new api did not support English stories yet. So in bug 1829907, we fixed it by ensuring English browsers in the new regions did not use the new api.

Now that we're migrating everyone onto the new api, we need to undo this change.

Comment 1

[Scott [:thecount] Downe]

Options:

1. Delete the code added in bug 1829907 now in nightly. What this means is very soon the smallish number of English users in the new markets are going to essentially get English stories served from the new API. The new api now supports English stories, so this should be safe, but not extensively tested. It's nightly though, so it's reasonable if this breaks.
2. Turn off the pref so English users no longer see stories. It's a small group of people so the impact is low, but there may be some folks that are confused, which I am not thrilled about.
3. Keep them on the old API until the migration is complete, then remove the code added by bug 1829907.

Comment 2

[Scott [:thecount] Downe]

Attachment: Bug 1843130 - Pocket newtab move new markets with English browser in nightly to the new recs api.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69d4d8ce55ac
Pocket newtab move new markets with English browser in nightly to the new recs api. r=gvn

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/69d4d8ce55ac