1843135 - "Hide Local Folders" toggle affects "Show Total Messages" and "Show Folder Size"

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect, P2)

Description

[solange]

Steps to recreate:

• Toggle to show "Show Total Messages" and/or "Show Folder Size"
• Check "Hide Local Folders"

Expect result:

• local folders are hidden while "Total Messages" and "Folder Size" remain visible

Actual result:

• Total messages, Folder sizes and local folders are all hidden

Comment 1

[Alessandro Castellani [:aleca]]

Taking this as I have a patch, just finishing adding tests to make sure it works.
Also it's fixing bug 1836552, so if it works we can mark that as duplicate.

Comment 2

[Alessandro Castellani [:aleca]]

Attachment: Bug 1843135 - Fix various out of sync states for the folder row total count and size properties. r=sol,micahilbery,freaktechnik

• Enable total count and folder size in the folder pane
• Move messages around, delete and restore messages to ensure the count and size are properly updated
• Create folders, toggle folder modes, and toggle local folders visibility to ensure the count badges visibility is respected

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f0a6b9ec4dbd
Fix various out of sync states for the folder row total count and size properties. r=micahilbery,freaktechnik

Comment 5

[Alessandro Castellani [:aleca]]

Comment on attachment 9343563 [details]
Bug 1843135 - Fix various out of sync states for the folder row total count and size properties. r=sol,micahilbery,freaktechnik

[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined: Many random out of syn states for total message count and folder size in the folder pane, as well as disappearing badges when local folders are hidden on startup.
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): Could be a bit above low, but not moderate, since a fair amount of logic was changed, but we now have tests to cover for these scenarios.

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9343563 [details]
Bug 1843135 - Fix various out of sync states for the folder row total count and size properties. r=sol,micahilbery,freaktechnik

[Triage Comment]
Approved for beta
Approved for esr115 assuming successful beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 116.0b7:
https://hg.mozilla.org/releases/comm-beta/rev/db9ddeaac20f

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 115.1.0:
https://hg.mozilla.org/releases/comm-esr115/rev/7fb0195c9605