1843198 - [wpt-sync] Sync PR 41010 - Add children and replaceChildren support to ChildNodePart

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 41010 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41010
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

Add children and replaceChildren support to ChildNodePart

This also changes IsValid for ChildNodePart to return false if the
endpoints are the same. It seems like there needs to be a "gap"
between them or things get weird when you do replaceChildren.

Bug: 1453291
Change-Id: I0b7b0a1d7e47a3e315d20cfa09d0e55c2c06f346
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4681916
Commit-Queue: Mason Freed \<[e-mail]>
Reviewed-by: David Baron \<[e-mail]>
Auto-Submit: Mason Freed \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1169613}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 41010 applied with additional changes from upstream: b9f2c32836b082ab21338b1ae0ad9f64648782be, b9c3f5026f7f352f099e17bf008ac33d15af1aa3, 7fa83ac7286923c96e698cc1eda93e28fe4a00e7, c1391d92ca3d26e2b8e543619154629f935b5502, 2b02e80a554b26a4655b73db5aee496fd8467e58

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3cb9c41baac0047f48083cb1a071ef4e92a9857

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 16 subtests

Status Summary

Firefox

OK : 1
FAIL: 16

Chrome

OK : 1
PASS: 1
FAIL: 15

Safari

OK : 1
FAIL: 16

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /dom/parts/basic-dom-part-objects.tentative.html [wpt.fyi]
  • Basic imperative DOM Parts object construction (Document): FAIL (Chrome: FAIL, Safari: FAIL)
  • Cloning (Document): FAIL (Chrome: FAIL, Safari: FAIL)
  • Cloning Element (Document): FAIL (Chrome: FAIL, Safari: FAIL)
  • Cloning Text (Document): FAIL (Chrome: FAIL, Safari: FAIL)
  • Cloning Comment (Document): FAIL (Chrome: FAIL, Safari: FAIL)
  • Cloning CDATASection (Document): FAIL (Chrome: FAIL, Safari: FAIL)
  • Cloning ProcessingInstruction (Document): FAIL (Chrome: FAIL, Safari: FAIL)
  • Basic imperative DOM Parts object construction (DocumentFragment): FAIL (Chrome: FAIL, Safari: FAIL)
  • Cloning (DocumentFragment): FAIL (Chrome: FAIL, Safari: FAIL)
  • Cloning Element (DocumentFragment): FAIL (Chrome: FAIL, Safari: FAIL)
  • Cloning Text (DocumentFragment): FAIL (Chrome: FAIL, Safari: FAIL)
  • Cloning Comment (DocumentFragment): FAIL (Chrome: FAIL, Safari: FAIL)
  • Cloning CDATASection (DocumentFragment): FAIL (Chrome: FAIL, Safari: FAIL)
  • Cloning ProcessingInstruction (DocumentFragment): FAIL (Chrome: FAIL, Safari: FAIL)
  • DOM mutation support: FAIL (Chrome: PASS, Safari: FAIL)
  • ChildNodePart children manipulation: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28d6fd0dc0b6
[wpt PR 41010] - Add children and replaceChildren support to ChildNodePart, a=testonly
https://hg.mozilla.org/integration/autoland/rev/a0257102281f
[wpt PR 41010] - Update wpt metadata, a=testonly

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/28d6fd0dc0b6
https://hg.mozilla.org/mozilla-central/rev/a0257102281f