1843239 - Consider to use [Pure, StoreInSlot] for Location.hash, or cache the value in C++

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Olli Pettay [:smaug][[e-mail]]]

Angular is accessing .hash a lot, yet the value of the hash value seems to stay the same.
I think [Pure, StoreInSlot] annotation should work in this case (even though we have a proxy around), similarly to window.performance.
Need to clear the slot when url changes.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Or if not StoreInSlot, then Cached

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

I'm investigating this.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1843239, optimize Location.hash, r=peterv

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1843239, add a test for the current location.hash handling in Gecko, r=peterv

Depends on D183788

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce4f02a4ad1e
[Cached] Location.hash, r=peterv

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afbaf4c16b44
add a test for the current location.hash handling in Gecko, r=peterv,dom-core

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a238650aa09
Backed out changeset ce4f02a4ad1e for causing multiple failures. CLOSED TREE

Comment 8

[Serban Stanca [:SerbanS]]

Backed out for causing multiple failures.

• Backout link

---

• Push with failures - reftests 1
• Failure Log
• Failure line: REFTEST PROCESS-CRASH | application crashed [@ libsystem_kernel.dylib + 0x0000000000000dfa] | file:///opt/worker/tasks/task_169081719997154/build/tests/reftest/tests/layout/reftests/margin-collapsing/reftest.list

---

• Push with failures - reftests 2
• Failure Log
• Failure line: REFTEST ERROR | TEST-UNEXPECTED-FAIL | image/test/crashtests/944353.jpg | application timed out after 370 seconds with no output

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/afbaf4c16b44

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a69f2deff29
optimize Location.hash, r=peterv,dom-core

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2a69f2deff29