1843261 - Remove browser.tabs.remote.desktopbehavior pref

Status: RESOLVED FIXED

(Core :: Widget, task, P5)

Description

[Gregory Pappas [:gregp]]

It's not clear to me what exactly this pref is for. It's only read once in PuppetWidget::NeedsPaint.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Yeah I don't think we have WindowType::Popup in content process at all, probably should just be removed.

Comment 2

[Gregory Pappas [:gregp]]

Attachment: Bug 1843261 - Remove browser.tabs.remote.desktopbehavior pref r?emilio!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/732937ff77f9
Remove browser.tabs.remote.desktopbehavior pref r=emilio

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing assertion failures in widget/PuppetWidget.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/255a1a956d0f1bab4f46a48bd3ecbe28827d2d8e

Push with failures

Failure log -> Assertion failure: mWindowType != WindowType::Popup, at /builds/worker/checkouts/gecko/widget/PuppetWidget.cpp:998

Comment 5

[Gregory Pappas [:gregp]]

Fascinating.

It looks like the failure comes from 336999-1.xhtml (bug 336999)

Is this even possible normally? As in, <menulist><menupopup></menupopup></menulist> in content, or is it just this crashtest?

Comment 6

[Gregory Pappas [:gregp]]

(has any crashtest or reftest that involves menupopup in content been semi-broken the whole time? I don't know much about the reftest harness so not sure)

Comment 7

[Emilio Cobos Álvarez (:emilio)]

(In reply to Gregory Pappas [:gregp] from comment #6)

(has any crashtest or reftest that involves menupopup in content been semi-broken the whole time? I don't know much about the reftest harness so not sure)

Yeah, menupopup can't work in the child process. I'd just remove that test, it's broken.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b33eb976812
Remove browser.tabs.remote.desktopbehavior pref r=emilio

Comment 9

[Sandor Molnar[:smolnar]]

Backed out for causing assertion failures in widget/PuppetWidget.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/fd8fb7be79bb55c487b5259c4a57ccf507c61403

Push with failures

Failure log -> Assertion failure: mWindowType != WindowType::Popup, at /builds/worker/checkouts/gecko/widget/PuppetWidget.cpp:998

Comment 10

[Gregory Pappas [:gregp]]

Another one. This time it's 360339-1.xhtml.

Emilio, we have about 15 crashtests that involve menupopup. Is it ok to remove all of them?

Comment 11

[Gregory Pappas [:gregp]]

For now, let's just annotate the broken tests

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a5caf74dcfe
Remove browser.tabs.remote.desktopbehavior pref r=emilio

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/8a5caf74dcfe